Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Update registry to use name as the canonical identifier for derived rendering types #246

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

samuelmale
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This fixes the issue related to rendering types: encounter-provider, encounter-location, problem and drug reported not working.

Screenshots

Related Issue

Other

Copy link

Size Change: -24 B (0%)

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
dist/17.js 16.6 kB 0 B
dist/184.js 11.2 kB 0 B
dist/225.js 2.57 kB 0 B
dist/29.js 206 kB 0 B
dist/300.js 592 B 0 B
dist/327.js 1.59 kB 0 B
dist/335.js 958 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.36 kB 0 B
dist/422.js 3.03 kB 0 B
dist/439.js 6.24 kB 0 B
dist/499.js 2.5 kB 0 B
dist/505.js 7.46 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 752 B 0 B
dist/581.js 203 kB 0 B
dist/606.js 2.23 kB 0 B
dist/635.js 14.2 kB 0 B
dist/767.js 79.1 kB 0 B
dist/780.js 240 kB -11 B (0%)
dist/886.js 6.94 kB 0 B
dist/942.js 482 B 0 B
dist/99.js 692 B 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 311 kB -13 B (0%)
dist/openmrs-form-engine-lib.js 3.81 kB 0 B

compressed-size-action

@denniskigen
Copy link
Member

Thanks, @samuelmale. I can confirm that this fixes the regression when running the linked library locally:

CleanShot 2024-04-30 at 2  18 48@2x

@denniskigen denniskigen merged commit 68da02b into main Apr 30, 2024
4 checks passed
@denniskigen denniskigen deleted the fix/derivedRenderings branch April 30, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants