Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add support for lab orders #249

Merged
merged 7 commits into from
May 3, 2024
Merged

(feat) Add support for lab orders #249

merged 7 commits into from
May 3, 2024

Conversation

samuelmale
Copy link
Member

@samuelmale samuelmale commented Apr 30, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR basically introduces support for capturing lab orders. The overwhelming consensus on how to capture orders in O3 is through the order basket, we are introducing this support to achieve parity with AFE.

Out of scope

I took the liberty of doing some housekeeping by introducing the EncounterFormManager which simply houses utils that facilitate encounter submission. This is a step forward towards simplifying the bloated EncounterForm component.

Potential improvements

  • Auto focus to freshly replicated group when user clicks "Add"
  • Prompt user with a confirmation modal upon deletion of a repeated row.
  • Use formFieldPath to consistently reconstruct the orders tree

Screenshots

https://www.loom.com/share/2ea596e09d474ece88de3312c26cccc5

Related Issue

https://openmrs.atlassian.net/browse/O3-3103

Other

N/A

@samuelmale samuelmale marked this pull request as ready for review April 30, 2024 21:56
Copy link

github-actions bot commented Apr 30, 2024

Size Change: -450 kB (-28%) 🎉

Total Size: 1.13 MB

Filename Size Change
dist/410.js 0 B -240 kB (removed) 🏆
dist/581.js 0 B -203 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
dist/17.js 16.6 kB 0 B
dist/184.js 11.2 kB 0 B
dist/225.js 2.57 kB 0 B
dist/29.js 206 kB 0 B
dist/300.js 700 B +108 B (+18%) ⚠️
dist/327.js 1.68 kB 0 B
dist/333.js 241 kB 0 B
dist/335.js 958 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.36 kB 0 B
dist/422.js 3.03 kB 0 B
dist/432.js 205 kB 0 B
dist/439.js 0 B -6.24 kB (removed) 🏆
dist/499.js 2.5 kB 0 B
dist/505.js 7.46 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 752 B 0 B
dist/568.js 4.72 kB 0 B
dist/606.js 2.23 kB 0 B
dist/635.js 14.2 kB 0 B
dist/767.js 79.1 kB 0 B
dist/886.js 6.94 kB 0 B
dist/942.js 482 B 0 B
dist/99.js 692 B 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 310 kB -949 B (0%)
dist/openmrs-form-engine-lib.js 3.81 kB +2 B (0%)

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @samuelmale. I've left some nitpicky suggestions, but the work overall LGTM!

src/transformers/angular-fe-schema-transformer.ts Outdated Show resolved Hide resolved
src/transformers/angular-fe-schema-transformer.ts Outdated Show resolved Hide resolved
src/submission-handlers/testOrderHandler.ts Show resolved Hide resolved
src/submission-handlers/testOrderHandler.ts Show resolved Hide resolved
src/form-engine.test.tsx Show resolved Hide resolved
src/components/repeat/repeat-controls.component.tsx Outdated Show resolved Hide resolved
src/components/repeat/repeat.component.tsx Show resolved Hide resolved
src/components/repeat/repeat.component.tsx Outdated Show resolved Hide resolved
@denniskigen
Copy link
Member

Whoops, sorry about the conflicts.

@denniskigen denniskigen merged commit e11d1fb into main May 3, 2024
4 checks passed
@denniskigen denniskigen deleted the feat/labOrders branch May 3, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants