-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add support for lab orders #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmale
force-pushed
the
feat/labOrders
branch
from
April 30, 2024 21:01
c38b5fc
to
17cae7f
Compare
Size Change: -450 kB (-28%) 🎉 Total Size: 1.13 MB
ℹ️ View Unchanged
|
denniskigen
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @samuelmale. I've left some nitpicky suggestions, but the work overall LGTM!
Whoops, sorry about the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR basically introduces support for capturing lab orders. The overwhelming consensus on how to capture orders in O3 is through the order basket, we are introducing this support to achieve parity with AFE.
Out of scope
I took the liberty of doing some housekeeping by introducing the
EncounterFormManager
which simply houses utils that facilitate encounter submission. This is a step forward towards simplifying the bloatedEncounterForm
component.Potential improvements
formFieldPath
to consistently reconstruct the orders treeScreenshots
https://www.loom.com/share/2ea596e09d474ece88de3312c26cccc5
Related Issue
https://openmrs.atlassian.net/browse/O3-3103
Other
N/A