Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) Fix broken "z-score" related unit test #255

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

samuelmale
Copy link
Member

@samuelmale samuelmale commented May 5, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Changes in this PR fix a broken time sensitive test by making sure the internally referenced date is static as opposed to being a moving target.

Screenshots

Screenshot 2024-05-06 at 00 31 17

Related Issue

N/A

Other

N/A

@samuelmale samuelmale marked this pull request as ready for review May 5, 2024 21:36
@@ -114,7 +114,7 @@ export const mockPatientAge4 = {
],
};

export const mockPatientAge16 = {
export const mockPatientAge8 = {
Copy link
Member Author

@samuelmale samuelmale May 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying patient record is 8 years relative to the referenced date.

Copy link

github-actions bot commented May 5, 2024

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size
dist/184.js 11.2 kB
dist/225.js 2.57 kB
dist/29.js 206 kB
dist/300.js 700 B
dist/327.js 1.68 kB
dist/333.js 241 kB
dist/335.js 958 B
dist/353.js 3.02 kB
dist/41.js 3.36 kB
dist/422.js 3.03 kB
dist/505.js 6.94 kB
dist/540.js 2.63 kB
dist/546.js 4.98 kB
dist/55.js 752 B
dist/59.js 5.59 kB
dist/606.js 2.23 kB
dist/635.js 14.2 kB
dist/782.js 4.37 kB
dist/789.js 203 kB
dist/794.js 16.6 kB
dist/942.js 482 B
dist/977.js 80.8 kB
dist/99.js 692 B
dist/993.js 3.08 kB
dist/main.js 310 kB
dist/openmrs-form-engine-lib.js 3.81 kB

compressed-size-action

@samuelmale samuelmale requested a review from pirupius May 6, 2024 08:52
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation on the call we had earlier, @samuelmale.

@denniskigen denniskigen merged commit 6d9ba6f into main May 6, 2024
4 checks passed
@denniskigen denniskigen deleted the fix/brokenTests branch May 6, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants