Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Miscellaneous improvements #26

Merged
merged 1 commit into from
Apr 19, 2023
Merged

(fix) Miscellaneous improvements #26

merged 1 commit into from
Apr 19, 2023

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Apr 18, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Adds some miscellaneous improvements, including:

  • Constraining the height of the LinearLoader component when loading a form's dependencies.
  • Making the display of the patient banner non-contingent on the availability of a patient UUID. Presently, the form schema will fail to render in some scenarios when a patientUuid is unavailable.

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

Size Change: +58 B (0%)

Total Size: 734 kB

ℹ️ View Unchanged
Filename Size Change
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/294.js 2.63 kB 0 B
dist/366.js 6.94 kB 0 B
dist/472.js 34.6 kB +21 B (0%)
dist/591.js 2.96 kB 0 B
dist/595.js 106 kB 0 B
dist/634.js 777 B 0 B
dist/709.js 2.42 kB 0 B
dist/852.js 174 kB 0 B
dist/986.js 193 kB 0 B
dist/main.js 192 kB +37 B (0%)
dist/openmrs-form-engine-lib.js 3.25 kB 0 B

compressed-size-action

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denniskigen These changes look similar to a greater extent to #27 that has already been merged. Will wait for a rebase to take another look at any specific changes

@pirupius pirupius merged commit e33aafa into main Apr 19, 2023
@pirupius pirupius deleted the fix/misc-improvements branch April 19, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants