(fix) Fix conditional access check affecting patientIdentifier type fields

[gitcliff]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

This PR is addressing the issue whereby after saving a form of patient identifier type, upon subsequent attempts to reload the form in the form-renderer the schema fails to load.

Screenshots

https://www.loom.com/share/7d5e92a9e98c423cb05270701f7539cb

Related Issue

Other

[samuelmale]

The title of the PR mentions adding some kind of validation but I don't see any validation specific logic, all I see is optional chaining. @gitcliff is this a WIP?

[gitcliff]

@samuelmale this PR covers the initial part of failure to load the form schema for patient identifier questions, this was discovered during the patientIdentifier validation for testing. Going to raise another PR that cover the patient Identifier validation.
Thanks

[samuelmale]

@gitcliff the PR title doesn't clearly describe what the changes are about. Is it fixing a reference to null/undefined prop or it's enabling loading of the form schema for patient Identifier type Questions? The title is a bit ambiguous.

[gitcliff]

@gitcliff the PR title doesn't clearly describe what the changes are about. Is it fixing a reference to null/undefined prop or it's enabling loading of the form schema for patient Identifier type Questions? The title is a bit ambiguous.

@samuelmale its **Fixing reference to null prop when loading the form schema for patient Identifier type Questions **

[hadijahkyampeire]

LGTM

[samuelmale]

Just one minor suggestion, but this is good to go.