Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-3164 switch to openmrsFetch to fetch encounter #266

Merged
merged 4 commits into from
May 12, 2024

Conversation

pirupius
Copy link
Member

@pirupius pirupius commented May 10, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Switches useEncounter from useSWR to openmrsFecth. Whereas this had some performance benefits, it’s at the cost of loading stale data. renamed the hook from useEncounter to getEncounter

Screenshots

Screen.Recording.2024-05-10.at.11.16.14.mov

Related Issue

https://openmrs.atlassian.net/browse/O3-3164

Other

Copy link

github-actions bot commented May 10, 2024

Size Change: -108 kB (-8.74%) ✅

Total Size: 1.12 MB

Filename Size Change
dist/794.js 0 B -16.6 kB (removed) 🏆
dist/977.js 0 B -80.8 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
dist/184.js 11.2 kB 0 B
dist/225.js 2.56 kB -4 B (-0.16%)
dist/29.js 206 kB 0 B
dist/300.js 695 B 0 B
dist/327.js 1.68 kB 0 B
dist/335.js 955 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.36 kB -4 B (-0.12%)
dist/422.js 0 B -3.03 kB (removed) 🏆
dist/436.js 752 B 0 B
dist/505.js 6.94 kB 0 B
dist/540.js 2.63 kB 0 B
dist/546.js 4.98 kB 0 B
dist/55.js 2.14 kB +1.39 kB (+185.31%) 🆘
dist/59.js 5.59 kB 0 B
dist/606.js 0 B -2.23 kB (removed) 🏆
dist/635.js 14.2 kB 0 B
dist/66.js 78.5 kB 0 B
dist/782.js 0 B -4.37 kB (removed) 🏆
dist/789.js 203 kB 0 B
dist/797.js 18.7 kB 0 B
dist/853.js 242 kB +70 B (+0.03%)
dist/942.js 482 B 0 B
dist/99.js 690 B 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 309 kB -2.25 kB (-0.72%)
dist/openmrs-form-engine-lib.js 3.81 kB +1 B (+0.03%)

compressed-size-action

@pirupius pirupius marked this pull request as ready for review May 10, 2024 09:35
@pirupius pirupius requested a review from samuelmale May 10, 2024 09:35
@samuelmale samuelmale force-pushed the fix/O3-3164/switch-to-openmrsFetch-in-useEncounter branch from 16c5bba to e80beac Compare May 12, 2024 13:33
@samuelmale samuelmale merged commit 12159d6 into main May 12, 2024
4 checks passed
@samuelmale samuelmale deleted the fix/O3-3164/switch-to-openmrsFetch-in-useEncounter branch May 12, 2024 16:57
vasharma05 pushed a commit that referenced this pull request May 27, 2024
* (fix) O3-3164 switch to openmrsFetch to fetch encounter

* refactors to useEncounter

* Clean up

* Fixup

---------

Co-authored-by: samuelmale <samuelsmalek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants