(fix) make visit information available within expression context #269
Conversation
arodidev
changed the title
| @@ -42,7 +42,7 @@ interface EncounterFormProps { | |||
| formSessionDate: Date; | |||
| provider: string; | |||
| location: SessionLocation; | |||
| visit?: Visit; | |||
| visit: Visit; | |||
There was a problem hiding this comment.
Are we now making the visit mandatory?
There was a problem hiding this comment.
Yes, since it is now not being passed as a prop but rather being fetched within the root component, it wouldn't make sense to have it as optional anymore yet it is always available.
src/form-engine.test.tsx
Outdated
| visit={visit} | ||
| />, | ||
| ); | ||
| render(<FormEngine formJson={formJson} formUUID={formUUID} patientUUID={patientUUID} formSessionIntent={intent} />); |
There was a problem hiding this comment.
What happens if its RDE? How do you know the visit to use if the visit uuid or visit is not passed as a prop?
There was a problem hiding this comment.
I am not entirely sure what RDE is, please explain. For the second part, currently I am picking the current visit.
@samuelmale This doesn't seem to be the case from my side.
Could you show how to replicate your findings above? |
|
@arodidev I didn't understand why it is necessary for the form-engine to load the visit by itself; what are the issues with the current setup? |
Well, considering we are getting the visit from the |
|
Ideally, I think the form engine wouldn't be calling |
…-lib into adding-visit-type-uuid
arodidev
changed the title
arodidev
changed the title
…-lib into adding-visit-type-uuid
| @@ -60,6 +64,7 @@ export function evaluateExpression( | |||
| sex, | |||
| age, | |||
| HD, | |||
| visitTypeUuid, | |||
There was a problem hiding this comment.
Can you also add this to the evaluateAsyncExpression?
* MVP * Cleanup * Adapt tests to new format * revert to visit as a prop * remove unnecessary visit * expand context for async-exp
Requirements
Summary
This PR aims to provide visit information (
visitTypeUuid) to the expression context to be used for expression evaluation.Screenshots
Related Issue
Other