(fix) revise logic for saving attachments

[arodidev]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

This PR seeks to ensure that no request is made to the attachments endpoint if no field bearing an attachment was filled at the point of submission.

Screenshots

Related Issue

Other

[samuelmale]

Can you just make sure that if there are zero attachments this function returns an empty value for attachmentsResponse and implement the necessary filters internally?

[arodidev]

You mean something like this?

const evaluatedFields = EncounterFormManager.evaluatedAttachmentFields(fields);
if (evaluatedFields?.length) {
  try {
    const attachmentsResponse = await Promise.all(
      EncounterFormManager.saveAttachments(fields, savedEncounter, abortController),
    );
    if (attachmentsResponse?.length) {
      showSnackbar({
        title: t('attachmentsSaved', 'Attachment(s) saved successfully'),
        kind: 'success',
        isLowContrast: true,
      });
    }
  } catch (error) {
    const errorMessages = extractErrorMessagesFromResponse(error);
    return Promise.reject({
      title: t('errorSavingAttachments', 'Error saving attachment(s)'),
      subtitle: errorMessages.join(', '),
      kind: 'error',
      isLowContrast: false,
    });
  }
} else {
  return [];
}

[CynthiaKamau]

I think the logic can be handled in the EncounterFormManager.saveAttachments function,

  static saveAttachments(fields: FormField[], encounter: OpenmrsEncounter, abortController: AbortController) {
    const complexFields = fields?.filter((field) => field?.questionOptions.rendering === 'file');
    return complexFields.map((field) => {
      const patientUuid = typeof encounter?.patient === 'string' ? encounter?.patient : encounter?.patient?.uuid;
      return saveAttachment(
        patientUuid,
        field,
        field?.questionOptions.concept,
        new Date().toISOString(),
        encounter?.uuid,
        abortController,
      );
    });
  }

Somewhere in here, before return saveAttachment(

[arodidev]

Thanks for the clarification @CynthiaKamau