Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Hide empty repeating groups #275

Merged
merged 2 commits into from
May 16, 2024
Merged

(feat) Hide empty repeating groups #275

merged 2 commits into from
May 16, 2024

Conversation

samuelmale
Copy link
Member

@samuelmale samuelmale commented May 16, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR aims at ensuring that empty repeat fields are hidden.

Screenshots

Issue:

Screenshot 2024-05-16 at 22 54 24

Solved:

2024-05-16 22-59-24 2024-05-16 23_00_50

Related Issue

N/A

Other

Comment on lines 1 to 3
{
"cSpell.words": ["fhir", "Openmrs"]
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oppsss!!

Copy link

github-actions bot commented May 16, 2024

Size Change: +85 B (+0.01%)

Total Size: 1.12 MB

ℹ️ View Unchanged
Filename Size Change
dist/125.js 5.64 kB 0 B
dist/184.js 11.2 kB 0 B
dist/225.js 2.56 kB 0 B
dist/29.js 206 kB 0 B
dist/300.js 682 B 0 B
dist/327.js 1.72 kB 0 B
dist/335.js 955 B 0 B
dist/353.js 3.02 kB 0 B
dist/368.js 241 kB +40 B (+0.02%)
dist/41.js 3.36 kB 0 B
dist/432.js 203 kB 0 B
dist/436.js 752 B 0 B
dist/505.js 6.94 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 2.14 kB 0 B
dist/635.js 14.2 kB 0 B
dist/66.js 78.5 kB 0 B
dist/760.js 5.25 kB 0 B
dist/797.js 18.7 kB 0 B
dist/942.js 482 B 0 B
dist/99.js 690 B 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 309 kB +45 B (+0.01%)
dist/openmrs-form-engine-lib.js 3.82 kB 0 B

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @samuelmale.

@samuelmale samuelmale merged commit 560e903 into main May 16, 2024
4 checks passed
@samuelmale samuelmale deleted the feat/hideEmptyGroup branch May 16, 2024 20:26
@samuelmale samuelmale restored the feat/hideEmptyGroup branch May 16, 2024 20:33
vasharma05 pushed a commit that referenced this pull request May 27, 2024
* Hide empty repeating groups

* Remove vscode related file
@samuelmale samuelmale deleted the feat/hideEmptyGroup branch May 27, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants