-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Support for an capturing encounter role. #279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -240 kB (-18.55%) 👏 Total Size: 1.05 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hadijahkyampeire, i have left some few comments
arodidev
reviewed
May 21, 2024
hadijahkyampeire
force-pushed
the
hk-encounter-role-control
branch
from
May 21, 2024 10:40
94b240f
to
9527f90
Compare
kajambiya
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
arodidev
added a commit
to arodidev/openmrs-form-engine-lib
that referenced
this pull request
May 22, 2024
support convSets and Coded concepts cleanup FIx tests type configurations and miscellaneous additions (feat) Support for an capturing encounter role. (openmrs#279) * add support for encounter role control * remove console.log * add role to tests * revert some changes * tweak the url rep * fix patientIdentifier test
vasharma05
pushed a commit
that referenced
this pull request
May 27, 2024
* add support for encounter role control * remove console.log * add role to tests * revert some changes * tweak the url rep * fix patientIdentifier test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
encounterRole
question, the selected role overrides the defaultClinian
role.Screenshots
encounter-role.mov
Related Issue
Other