Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Support for an capturing encounter role. #279

Merged
merged 6 commits into from
May 22, 2024

Conversation

hadijahkyampeire
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire commented May 20, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • This PR adds support for choosing an encounter role, if a form has an encounterRole question, the selected role overrides the default Clinian role.

Screenshots

Screenshot 2024-05-20 at 11 12 14
  • Recording
encounter-role.mov

Related Issue

Other

Copy link

github-actions bot commented May 20, 2024

Size Change: -240 kB (-18.55%) 👏

Total Size: 1.05 MB

Filename Size Change
dist/368.js 0 B -240 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
dist/184.js 11.2 kB 0 B
dist/225.js 2.56 kB 0 B
dist/29.js 157 kB 0 B
dist/300.js 682 B 0 B
dist/31.js 4.9 kB 0 B
dist/318.js 2.42 kB 0 B
dist/327.js 1.71 kB 0 B
dist/335.js 955 B 0 B
dist/353.js 3.02 kB 0 B
dist/371.js 71.5 kB +5 B (+0.01%)
dist/41.js 3.36 kB 0 B
dist/436.js 752 B 0 B
dist/540.js 2.64 kB 0 B
dist/55.js 2.14 kB 0 B
dist/583.js 241 kB 0 B
dist/635.js 14.3 kB 0 B
dist/779.js 203 kB 0 B
dist/8.js 3.67 kB 0 B
dist/942.js 482 B 0 B
dist/979.js 6.85 kB 0 B
dist/99.js 690 B 0 B
dist/993.js 3.08 kB 0 B
dist/998.js 15.5 kB 0 B
dist/main.js 298 kB +182 B (+0.06%)
dist/openmrs-form-engine-lib.js 3.76 kB -3 B (-0.08%)

compressed-size-action

Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hadijahkyampeire, i have left some few comments

src/form-engine.component.tsx Show resolved Hide resolved
src/submission-handlers/encounterRoleHandler.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@kajambiya kajambiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hadijahkyampeire hadijahkyampeire merged commit 9c05e29 into main May 22, 2024
4 checks passed
@hadijahkyampeire hadijahkyampeire deleted the hk-encounter-role-control branch May 22, 2024 12:57
arodidev added a commit to arodidev/openmrs-form-engine-lib that referenced this pull request May 22, 2024
support convSets and Coded concepts

cleanup

FIx tests

type configurations and miscellaneous additions

(feat) Support for an capturing encounter role. (openmrs#279)

* add support for encounter role control

* remove console.log

* add role to tests

* revert some changes

* tweak the url rep

* fix patientIdentifier test
vasharma05 pushed a commit that referenced this pull request May 27, 2024
* add support for encounter role control

* remove console.log

* add role to tests

* revert some changes

* tweak the url rep

* fix patientIdentifier test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants