Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix):Fixed position of save/cancel button on form engine #29

Merged
merged 2 commits into from
Apr 19, 2023
Merged

(fix):Fixed position of save/cancel button on form engine #29

merged 2 commits into from
Apr 19, 2023

Conversation

makombe
Copy link
Contributor

@makombe makombe commented Apr 18, 2023 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Screenshot from 2023-04-18 13-23-39
Screenshot from 2023-04-18 13-24-37

donaldkibet
donaldkibet approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@donaldkibet donaldkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @makombe

donaldkibet
donaldkibet approved these changes Apr 19, 2023
View reviewed changes
src/ohri-form.scss Outdated
}

.minifiedButtons {
width: 100%;
height: 63.5px;
position: absolute ;
bottom: 0;
margin-top: 10rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try remove the margin-bottom i think it would not have any effect on the UI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice observation, fixed. Thanks

@pirupius pirupius merged commit c193efa into openmrs:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirupius pirupius pirupius approved these changes

@donaldkibet donaldkibet donaldkibet approved these changes

@denniskigen denniskigen Awaiting requested review from denniskigen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makombe @pirupius @donaldkibet