Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) follow-up fix for file attachment logic #295

Merged
merged 1 commit into from
May 28, 2024
Merged

(fix) follow-up fix for file attachment logic #295

merged 1 commit into from
May 28, 2024

Conversation

arodidev
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR expands the filter for file attachment logic and removes fields of rendering file that have no submission value.

Screenshots

Related Issue

Other

@arodidev arodidev changed the title (fix) follow-fix for file attachment logic (fix) follow-up fix for file attachment logic May 27, 2024
CynthiaKamau
CynthiaKamau approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @arodidev

@arodidev arodidev merged commit 5b158e5 into openmrs:main May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CynthiaKamau CynthiaKamau CynthiaKamau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arodidev @CynthiaKamau