Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O3-2061: Introduce visit as an optional parameter to the form-engine #30

Merged
merged 1 commit into from
Apr 20, 2023
Merged

O3-2061: Introduce visit as an optional parameter to the form-engine #30

merged 1 commit into from
Apr 20, 2023

Conversation

CynthiaKamau
Copy link
Contributor

@CynthiaKamau CynthiaKamau commented Apr 18, 2023 •
edited by denniskigen
Loading

… fields

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Passed active visit uuid in form if it exists

Screenshots

visit uuid

Related Issue

Other

samuelmale
samuelmale reviewed Apr 19, 2023
View reviewed changes
Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass active visit attributes as default

Changes in this PR don't fully satisfy the above. I would expect you to fetch the current visit and use that to initialise the necessary properties ie. encounterDatetime, provider and location

src/components/encounter/ohri-encounter-form.tsx Outdated Show resolved Hide resolved
@pirupius pirupius mentioned this pull request Apr 19, 2023
Closed
3 tasks
@CynthiaKamau CynthiaKamau mentioned this pull request Apr 19, 2023
Merged
3 tasks
@samuelmale samuelmale changed the title O3-2061 Pass active visit attributes as default in visit related form… O3-2061: Introduce visit as an optional parameter to the form-engine Apr 20, 2023
@samuelmale samuelmale merged commit cd4a9e6 into openmrs:main Apr 20, 2023
eudson pushed a commit to eudson/openmrs-form-engine-lib that referenced this pull request Apr 21, 2023
@CynthiaKamau @eudson
O3-2061 Pass active visit attributes as default in visit related form…
680d6d7 
… fields (openmrs#30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmale samuelmale samuelmale approved these changes

@donaldkibet donaldkibet donaldkibet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CynthiaKamau @samuelmale @donaldkibet