(refactor)03-3321: Move encounter role(s) logic to the encounter-form component #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh i see ,,, thanks @CynthiaKamau |
arodidev
reviewed
Jun 4, 2024
arodidev
approved these changes
Jun 4, 2024
samuelmale
reviewed
Jun 4, 2024
| const [fields, setFields] = useState<Array<FormField>>([]); | ||
| const [encounterLocation, setEncounterLocation] = useState(null); | ||
| const [encounterDate, setEncounterDate] = useState(formSessionDate); | ||
| const [encounterProvider, setEncounterProvider] = useState(provider); | ||
| const [encounterRole, setEncounterRole] = useState(role); | ||
| const [encounterRole, setEncounterRole] = useState(newEncounterRole?.uuid); |
There was a problem hiding this comment.
This won't correctly initialise the encounterRole state, it will introduce a regression for forms without a field capturing an encounter role.
| @@ -86,11 +85,12 @@ const EncounterForm: React.FC<EncounterFormProps> = ({ | |||
| isSubmitting, | |||
| }) => { | |||
| const { t } = useTranslation(); | |||
| const { newEncounterRole, isLoading: isLoadingEncounterRole } = useEncounterRole(); | |||
There was a problem hiding this comment.
I would treat this more like a "default" role.
samuelmale
changed the title
samuelmale
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
PR is enabling the loading of encounter roles from the encounter-form component
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3321
Other