Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(test) Adding test coverage for the encounter role handler #301

Merged
merged 2 commits into from
Jun 4, 2024
Merged

(test) Adding test coverage for the encounter role handler #301

merged 2 commits into from
Jun 4, 2024

Conversation

gitcliff
Copy link
Contributor

@gitcliff gitcliff commented May 29, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Adding test coverage for the encounter role handler for handlingFieldSubmission, getting initial and prevoius values

Screenshots

Related Issue

Other

@pirupius pirupius changed the title (test):Adding test coverage for the encounter role handler (test) Adding test coverage for the encounter role handler May 30, 2024
samuelmale
samuelmale reviewed May 31, 2024
View reviewed changes
Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use a single test suite?

src/submission-handlers/encounterRolesHandler.test.ts Outdated Show resolved Hide resolved
src/submission-handlers/encounterRolesHandler.test.ts Outdated
// replay
const role = EncounterRoleHandler.handleFieldSubmission(field, 'Clinician', encounterContext);
// verify
expect(role).toEqual('Clinician');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the right place to do the assertion is against the encounter context (Same applies to other places):

encounterContext.encounterRole

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i have updated this for the cases in the handler dealing with the encounterContext ie here and here

src/submission-handlers/encounterRolesHandler.test.ts Outdated Show resolved Hide resolved
@samuelmale samuelmale merged commit c4f0b51 into openmrs:main Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmale samuelmale samuelmale approved these changes

@pirupius pirupius Awaiting requested review from pirupius

@denniskigen denniskigen Awaiting requested review from denniskigen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitcliff @samuelmale