Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Remove redundant "value" state derived from the "previous value" #306

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

gitcliff
Copy link
Contributor

@gitcliff gitcliff commented Jun 5, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR is removing the redundant value state coming from the previous value across all components in the engine

Screenshots

Related Issue

Other

@gitcliff gitcliff requested a review from samuelmale June 5, 2024 07:16
@samuelmale samuelmale changed the title (fix):Removing value state (refactor) Remove redundant "value" state derived from the "previous value" Jun 5, 2024
@samuelmale
Copy link
Member

@gitcliff can you ensure that the cleanup cuts across all components?

@gitcliff
Copy link
Contributor Author

gitcliff commented Jun 5, 2024

@gitcliff can you ensure that the cleanup cuts across all components?

@samuelmale i have added more cleanups
thanks

@samuelmale
Copy link
Member

Can you also add a summary of what this PR does?

@gitcliff
Copy link
Contributor Author

gitcliff commented Jun 5, 2024

Can you also add a summary of what this PR does?

thanks ...
Done

@samuelmale samuelmale merged commit 30e7a1f into openmrs:main Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants