(test):Adding some test coverage for form-helper functions #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandones
reviewed
Jul 3, 2024
| it('should parse valid date string with time correctly', () => { | ||
| const dateString = '2023-06-27T14:30:00'; | ||
| const expectedDate = new Date(2023, 5, 27, 14, 30, 0); | ||
| const parsedDate = parseToLocalDateTime(dateString); |
There was a problem hiding this comment.
@samuelmale why aren't we using parseDate?
There was a problem hiding this comment.
No good reason! I agree we should rely more on the utils exposed by the framework.
brandones
reviewed
Jul 3, 2024
brandones
reviewed
Jul 3, 2024
src/utils/form-helper.test.ts
Outdated
Comment on lines
474
to
487
|
|
||
| test('works with different patient data', () => { | ||
| patient = { id: 'patient2', name: 'Jane Doe' }; | ||
| mockExpressionRunnerFn.mockReturnValue(false); | ||
| const result = evaluateDisabled(node, allFields, allValues, sessionMode, patient, mockExpressionRunnerFn); | ||
| expect(result).toBe(false); | ||
| expect(mockExpressionRunnerFn).toHaveBeenCalledWith( | ||
| node.value.disabled.disableWhenExpression, | ||
| node, | ||
| allFields, | ||
| allValues, | ||
| { mode: sessionMode, patient }, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
I cannot imagine what could cause this test to fail. Why is this a useful test?
Suggested change
| test('works with different patient data', () => { | |
| patient = { id: 'patient2', name: 'Jane Doe' }; | |
| mockExpressionRunnerFn.mockReturnValue(false); | |
| const result = evaluateDisabled(node, allFields, allValues, sessionMode, patient, mockExpressionRunnerFn); | |
| expect(result).toBe(false); | |
| expect(mockExpressionRunnerFn).toHaveBeenCalledWith( | |
| node.value.disabled.disableWhenExpression, | |
| node, | |
| allFields, | |
| allValues, | |
| { mode: sessionMode, patient }, | |
| ); | |
| }); |
brandones
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Just the one question @gitcliff , otherwise LGTM. Please answer the question (or delete the test) and then we'll merge this in.
I'm not well-positioned to evaluate whether these are actually useful tests, or whether it is too much "testing implementation details." I will leave that evaluation to @samuelmale and @pirupius .
pirupius
approved these changes
Jul 4, 2024
Art-Ndiema
pushed a commit
to Art-Ndiema/openmrs-form-engine-lib
that referenced
this pull request
Aug 8, 2024
* (test):Adding some test coverage for form-helper functions * Update src/utils/form-helper.test.ts * deletes unecessary test --------- Co-authored-by: Brandon Istenes <brandonesbox@gmail.com> Co-authored-by: Pius Rubangakene <piruville@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
PR is adding test coverage for some form helper functions
Screenshots
Related Issue
Other