Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-3417: Disable save button while loading form dependencies #340

Merged
merged 1 commit into from
Jul 3, 2024
Merged

(fix) O3-3417: Disable save button while loading form dependencies #340

merged 1 commit into from
Jul 3, 2024

Conversation

arodidev
Copy link
Contributor

@arodidev arodidev commented Jul 3, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR introduces functionality that disables the save buttons while form dependencies are loading.

Screenshots

Screen.Recording.2024-07-03.at.07.12.38.mov

Related Issue

Other

@arodidev arodidev requested a review from kajambiya July 3, 2024 06:44
kajambiya
kajambiya approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@kajambiya kajambiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arodidev arodidev merged commit 5b6ba37 into openmrs:main Jul 3, 2024
4 checks passed
Art-Ndiema pushed a commit to Art-Ndiema/openmrs-form-engine-lib that referenced this pull request Aug 8, 2024
@arodidev @Art-Ndiema
MVP (openmrs#340)
82d107a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajambiya kajambiya kajambiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arodidev @kajambiya