Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure the 'filed mandatory' is only flagged when the field is Requir… #348

Closed
wants to merge 1 commit into from

Conversation

lucyjemutai
Copy link
Contributor

…ed and empty.

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR ensure the 'filed mandatory' is only flagged when the field is Required and empty.

Screenshots

image

Related Issue

Other

@lucyjemutai
Copy link
Contributor Author

Hey @arodidev I removed the general required Check
If the field is required and empty, it either uses the specific conditional required message or defaults to "Field is mandatory".

Kindly help me with review and test it locally on the onri-namibia-demo. Thanks

@lucyjemutai lucyjemutai marked this pull request as ready for review July 11, 2024 06:39
@arodidev
Copy link
Contributor

Closing this pull request as it does not resolve the issue at hand, as per our earlier discussion @lucyjemutai

@arodidev arodidev closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants