Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters out Empty/Hidden Sections in a Page #35

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Filters out Empty/Hidden Sections in a Page #35

merged 1 commit into from
Apr 20, 2023

Conversation

smallgod
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • This PR filters out empty Sections from Form pages. Empty Sections are sections that are either Hidden on the form page or sections that have no questions or whose questions are all Hidden.
  • There is some code improvements as well to the code filtering out sections

Screenshots

page-with-issue

okay-page

Related Issue

Other

donaldkibet
donaldkibet approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@donaldkibet donaldkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smallgod LGTM 🚀

src/components/page/ohri-form-page.tsx Outdated Show resolved Hide resolved
@smallgod smallgod closed this Apr 20, 2023
@pirupius pirupius reopened this Apr 20, 2023
@pirupius pirupius merged commit 45d8204 into openmrs:main Apr 20, 2023
eudson pushed a commit to eudson/openmrs-form-engine-lib that referenced this pull request Apr 21, 2023
@smallgod @eudson
PR changes (openmrs#35)
20d5964
CynthiaKamau pushed a commit to CynthiaKamau/openmrs-form-engine-lib that referenced this pull request Apr 25, 2023
@smallgod @CynthiaKamau
PR changes (openmrs#35)
568e140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirupius pirupius pirupius approved these changes

@donaldkibet donaldkibet donaldkibet approved these changes

@denniskigen denniskigen Awaiting requested review from denniskigen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smallgod @pirupius @donaldkibet