Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) Fix failing tests by removing partial framework mocks #359

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Related to openmrs/openmrs-esm-patient-management#1264.

This PR fixes failing assertions by removing partial mocks that extend the framework mock. We shouldn't need to extend the framework mock this way as it already provides most of the stubs one would need to mock out in a test. I couldn't get the FormEngine component tests to pass and couldn't figure out why. Any help figuring that out would be much appreciated. We'd need to get this PR in and then bump the library in Patient Chart as a prerequisite to fixing the same issue in Patient Chart. So this PR is a blocker in that sense.

Screenshots

Related Issue

Other

Copy link

github-actions bot commented Aug 2, 2024

Size Change: -599 kB (-33.54%) 🎉

Total Size: 1.19 MB

Filename Size Change
dist/195.js 0 B -76.6 kB (removed) 🏆
dist/29.js 0 B -166 kB (removed) 🏆
dist/673.js 0 B -245 kB (removed) 🏆
dist/752.js 0 B -116 kB (removed) 🏆
dist/main.js 358 kB +14.9 kB (+4.34%)
ℹ️ View Unchanged
Filename Size Change
dist/151.js 300 kB 0 B
dist/184.js 11.2 kB 0 B
dist/194.js 9.51 kB 0 B
dist/225.js 2.57 kB 0 B
dist/277.js 1.84 kB 0 B
dist/300.js 709 B 0 B
dist/327.js 0 B -1.84 kB (removed) 🏆
dist/335.js 967 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.36 kB 0 B
dist/422.js 6.79 kB 0 B
dist/474.js 116 kB 0 B
dist/491.js 0 B -9.18 kB (removed) 🏆
dist/540.js 2.63 kB 0 B
dist/55.js 756 B 0 B
dist/635.js 14.3 kB 0 B
dist/674.js 86.4 kB 0 B
dist/70.js 482 B 0 B
dist/776.js 3.2 kB 0 B
dist/888.js 259 kB 0 B
dist/99.js 690 B 0 B
dist/993.js 3.09 kB 0 B
dist/openmrs-form-engine-lib.js 3.72 kB +1 B (+0.03%)

compressed-size-action

@denniskigen
Copy link
Member Author

denniskigen commented Aug 6, 2024

So the resolution in the interim (until @samuelmale's Formik to RHF PR gets merged in), is that we'll disable the FormEngine component tests @NethmiRodrigo @ibacher

@ibacher ibacher merged commit c202984 into main Aug 6, 2024
4 checks passed
@ibacher ibacher deleted the test/fix-failing-assertions branch August 6, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants