(test) Fix failing tests by removing partial framework mocks #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Related to openmrs/openmrs-esm-patient-management#1264.
This PR fixes failing assertions by removing partial mocks that extend the framework mock. We shouldn't need to extend the framework mock this way as it already provides most of the stubs one would need to mock out in a test. I couldn't get the
FormEngine
component tests to pass and couldn't figure out why. Any help figuring that out would be much appreciated. We'd need to get this PR in and then bump the library in Patient Chart as a prerequisite to fixing the same issue in Patient Chart. So this PR is a blocker in that sense.Screenshots
Related Issue
Other