(fix) O3-3743: Better success message when submitting a form. #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibacher could you please review this PR, your feedback will be appreciated. |
ibacher
approved these changes
Aug 8, 2024
translations/en.json
Outdated
Comment on lines
12
to
13
| "createdRecord": "Record created", | ||
| "createdRecordDescription": "A new encounter was created", |
There was a problem hiding this comment.
Any ideas why these keys didn't get removed?
There was a problem hiding this comment.
Thought they're being used somewhere else, is it okay if I remove them?!
There was a problem hiding this comment.
AFAICT, they're only used in the spot we fixed... If they were used somewhere else, that's somewhere else we should fix.
samuelmale
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Currently when submitting a form successfully, the message “A new encounter was created“ is displayed. This PR changes the success message to a better success message that says “Form submitted successfully“.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-3743