Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix patient banner #365

Merged
merged 1 commit into from
Aug 10, 2024
Merged

(fix) Fix patient banner #365

merged 1 commit into from
Aug 10, 2024

Conversation

samuelmale
Copy link
Member

@samuelmale samuelmale commented Aug 9, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR addresses an issue with the patient banner not working as expected. The root cause was identified as the <Form> component from the Carbon Design System, which does not support ref forwarding. This caused the ref to remain null.

Screenshots

2024-08-09 14-16-17 2024-08-09 14_17_23

Related Issue

https://openmrs.atlassian.net/browse/O3-3740

Other

Copy link

github-actions bot commented Aug 9, 2024

Size Change: -50 B (0%)

Total Size: 1.14 MB

ℹ️ View Unchanged
Filename Size Change
dist/151.js 300 kB 0 B
dist/225.js 2.57 kB 0 B
dist/277.js 1.84 kB 0 B
dist/3.js 481 B 0 B
dist/300.js 710 B 0 B
dist/335.js 968 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.37 kB 0 B
dist/422.js 6.8 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 758 B 0 B
dist/572.js 252 kB +14 B (+0.01%)
dist/617.js 86.9 kB 0 B
dist/635.js 14.3 kB 0 B
dist/733.js 107 kB -64 B (-0.06%)
dist/901.js 11.8 kB 0 B
dist/99.js 691 B 0 B
dist/993.js 3.09 kB 0 B
dist/main.js 340 kB 0 B
dist/openmrs-esm-form-engine-lib.js 3.67 kB 0 B

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denniskigen denniskigen merged commit a809dbf into main Aug 10, 2024
4 checks passed
@denniskigen denniskigen deleted the fix/patientBanner branch August 10, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants