(fix) parse NumberInput value to Number #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmale
reviewed
Aug 20, 2024
| @@ -22,6 +22,11 @@ const NumberField: React.FC<FormFieldInputProps> = ({ field, value, errors, warn | |||
| } | |||
| }; | |||
|
|
|||
| const handleChange = (event) => { | |||
There was a problem hiding this comment.
Not a big deal but can we wrap this in a useCallback(..)?
samuelmale
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
The value from the NumberInput field was being captured as a string. As a result, the form-validator would return false when checking if the value is an integer.
Screenshots
Before fix:
Screen.Recording.2024-08-20.at.16.06.17.mov
After fix:
Screen.Recording.2024-08-20.at.16.07.54.mov
Related Issue
Other