-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature) Length Validation for TextInput Fields #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM just a nit
min: '5', | ||
max: '10', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for TextInput i feel having the name minLength
and maxLength
is more descriptive of what we want to achieve with it.
@donaldkibet let me issue a follow up PR to resolve this |
Thanks @donaldkibet I will issue a PR |
* Updated instructions for local development * Added length validation to text-input field + tests
Length based validation for
textInputField
component.min
andmax
character length.