(feat) Add ability to retrieve encounter type and default to unknown encounter role
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
force-pushed
the
enhancement/encounterRole
branch
from
d4d6d03
to
27a4bd1
Compare
samuelmale
reviewed
Apr 2, 2023
samuelmale
reviewed
Apr 2, 2023
samuelmale
approved these changes
Apr 2, 2023
donaldkibet
force-pushed
the
enhancement/encounterRole
branch
from
27a4bd1
to
363f287
Compare
pirupius
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
At the moment the
hardcode value for encounterRole isClinicianfor some implementors this might be missing. I have added the ability to retrieve theencounterRoleand add preference toClinicianas the default value if present. In its absence theUnKnownencounterRole is picked.@denniskigen @samuelmale @pirupius @larslemos What are your thoughts on this approach.