Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce maxLength and minLength params for text fields #41

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

pirupius
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Both text and number fields have been using min and max params which caused a little bit of confusion putting into consideration the context. This PR introduces minLength and maxLength specifically for field.length validation.

Screenshots

Related Issue

Other

@github-actions
Copy link

Size Change: +15 B (0%)

Total Size: 735 kB

ℹ️ View Unchanged
Filename Size Change
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/294.js 2.63 kB 0 B
dist/366.js 6.94 kB 0 B
dist/472.js 35.2 kB +6 B (0%)
dist/591.js 2.96 kB 0 B
dist/595.js 106 kB 0 B
dist/634.js 777 B 0 B
dist/709.js 2.42 kB 0 B
dist/852.js 174 kB 0 B
dist/986.js 193 kB 0 B
dist/main.js 192 kB +9 B (0%)
dist/openmrs-form-engine-lib.js 3.25 kB 0 B

compressed-size-action

@pirupius pirupius merged commit 9f19ff8 into main Apr 21, 2023
@pirupius pirupius deleted the fix/introduce-max-min-length-params-for-text-fields branch April 21, 2023 12:23
CynthiaKamau pushed a commit to CynthiaKamau/openmrs-form-engine-lib that referenced this pull request Apr 25, 2023
* Introduces maxLength and minLength fields for text length validation

* Fixes failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants