Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Await for async calculate expressions to resolve at initialisation #415

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

samuelmale
Copy link
Member

@samuelmale samuelmale commented Oct 18, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This fix resolves an issue where initial values from calculateExpressions weren't being persisted. This was mostly because the expressions are promises and the values were being set before the promise is resolved.

Screenshots

Related Issue

Other

Copy link

Size Change: 0 B

Total Size: 1.22 MB

ℹ️ View Unchanged
Filename Size
dist/151.js 378 kB
dist/225.js 2.57 kB
dist/277.js 1.84 kB
dist/300.js 642 B
dist/335.js 968 B
dist/343.js 253 kB
dist/353.js 3.02 kB
dist/41.js 3.37 kB
dist/420.js 108 kB
dist/422.js 6.8 kB
dist/540.js 2.63 kB
dist/55.js 758 B
dist/617.js 86.9 kB
dist/635.js 14.3 kB
dist/70.js 483 B
dist/901.js 11.8 kB
dist/99.js 691 B
dist/993.js 3.09 kB
dist/main.js 342 kB
dist/openmrs-esm-form-engine-lib.js 3.67 kB

compressed-size-action

@pirupius pirupius merged commit 0e10380 into main Oct 18, 2024
4 checks passed
@pirupius pirupius deleted the fix/resolveAsyncExpression branch October 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants