Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the ExpressionRunner's internal workings and enhance support for custom datasources #47

Merged

Conversation

samuelmale
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR streamlines the Expression Runner by removing the necessity for manually registering interdependent fields and incorporating value interpolation within referenced helper functions. Additionally, it revitalizes the support for custom arbitrary data sources within the engine.

Screenshots

2023-04-25 18-59-18 2023-04-25 20_17_33

Related Issue

https://www.notion.so/ucsf-ighs/Add-custom-data-sources-eg-HTS-ML-a6477780a99a48b09af1990d17ec9695

Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@CynthiaKamau CynthiaKamau merged commit e9a87ae into openmrs:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants