Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix validators for number and text inputs #49

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Apr 27, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes an issue with the number and text input validators that caused the validations to fail silently. Ultimately, this issue led to forms failing to POST when saved.

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Size Change: +165 B (0%)

Total Size: 687 kB

ℹ️ View Unchanged
Filename Size Change
dist/225.js 9.82 kB 0 B
dist/227.js 35.4 kB +89 B (0%)
dist/272.js 6.59 kB 0 B
dist/294.js 2.63 kB 0 B
dist/366.js 6.94 kB 0 B
dist/591.js 2.96 kB 0 B
dist/595.js 106 kB 0 B
dist/634.js 777 B 0 B
dist/709.js 2.42 kB 0 B
dist/79.js 150 kB 0 B
dist/986.js 193 kB 0 B
dist/main.js 168 kB +76 B (0%)
dist/openmrs-form-engine-lib.js 3.24 kB 0 B

compressed-size-action

Copy link

@ebambo ebambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelmale samuelmale merged commit 2474b4c into main Apr 27, 2023
@samuelmale samuelmale deleted the fix/validations branch April 27, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants