Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Fix repeating Form Sections issue #50

Merged
merged 3 commits into from
Apr 27, 2023
Merged

(fix) Fix repeating Form Sections issue #50

merged 3 commits into from
Apr 27, 2023

Conversation

smallgod
Copy link
Contributor

@smallgod smallgod commented Apr 27, 2023 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Fix the issue that was causing repeated sections and the empty sections bug when multiple sections (3 or more) are present.

Screenshots

Screenshot 2023-04-27 at 11 56 01

Screenshot 2023-04-27 at 11 56 15

Related Issue

Other

@denniskigen
Copy link
Member

Could you please annotate the screenshots with a bit more context, @smallgod?

@denniskigen denniskigen changed the title Fix repeating Form Sections issue (fix) Fix repeating Form Sections issue Apr 27, 2023
@samuelmale samuelmale merged commit e81bbe3 into openmrs:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmale samuelmale samuelmale approved these changes

@ebambo ebambo Awaiting requested review from ebambo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smallgod @denniskigen @samuelmale