Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Remove unused styles and style imports + add eslint rules #57

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Apr 27, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR:

  • Removes a bunch of unused stylesheets and styles.
  • Scopes some CSS selectors under the root component's scope to avoid polluting the global scope.
  • Deletes a style override affecting the login page (!).
  • Sets up a bunch of ESLint rules governing imports for carbon and lodash.

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Size Change: -3.83 kB (-1%)

Total Size: 543 kB

ℹ️ View Unchanged
Filename Size Change
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/290.js 81.1 kB 0 B
dist/294.js 2.63 kB 0 B
dist/366.js 6.94 kB 0 B
dist/554.js 32.4 kB -1.91 kB (-6%)
dist/591.js 2.96 kB 0 B
dist/595.js 106 kB 0 B
dist/634.js 777 B 0 B
dist/709.js 2.42 kB 0 B
dist/986.js 193 kB 0 B
dist/main.js 96 kB -1.92 kB (-2%)
dist/openmrs-form-engine-lib.js 3.25 kB 0 B

compressed-size-action

Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denniskigen denniskigen merged commit 430c7d0 into main Apr 28, 2023
@denniskigen denniskigen deleted the refactor/old-carbon-references branch April 28, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants