Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Support for conditionally hiding pages #61

Merged
merged 2 commits into from
May 2, 2023

Conversation

smallgod
Copy link
Contributor

@smallgod smallgod commented Apr 28, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Adds support for conditionally hiding pages if:

  • All the sections in the page definition have isHidden set to a "true".
  • All the questions of all the sections in the page have isHidden set to "true".
  • The page's isHidden property is set to "true".

Screenshots

Before: All the questions in the Examination Details section are hidden by validation rules, which means the page shouldn't get displayed at all

Screenshot 2023-04-28 at 11 13 05

After: The Examination Details section is appropriately hidden

Screenshot 2023-04-28 at 11 21 04

@denniskigen denniskigen force-pushed the fix-redundant-empty-page-issue branch from c40c347 to 8b418ad Compare May 2, 2023 21:53
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Arthur!

@denniskigen denniskigen changed the title (enhance) Enhancement to add support for hiding empty/hidden Pages (feat) Support for conditionally hiding pages May 2, 2023
@denniskigen denniskigen merged commit b2e4af9 into openmrs:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants