Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) follow up PR to fix error brought by introducing age and sex in execution context #65

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

donaldkibet
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This is a follow up PR to fix error where the expression runner was failing because in cases where we are evaluating the field validators the patient object isn't provided, since we are destructuring the patient object we run into an undefined error. This PR fixes that issue with undefined values. Secondly is to enhance the error handling by adding the failing expression to the dev-console

Screenshots

Related Issue

Other

@github-actions
Copy link

Size Change: +134 B (0%)

Total Size: 547 kB

ℹ️ View Unchanged
Filename Size Change
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/290.js 81.1 kB 0 B
dist/294.js 2.63 kB 0 B
dist/366.js 6.94 kB 0 B
dist/554.js 34.3 kB +64 B (0%)
dist/591.js 2.96 kB 0 B
dist/595.js 106 kB 0 B
dist/634.js 777 B 0 B
dist/709.js 2.42 kB 0 B
dist/986.js 193 kB 0 B
dist/main.js 97.9 kB +70 B (0%)
dist/openmrs-form-engine-lib.js 3.25 kB 0 B

compressed-size-action

@donaldkibet donaldkibet merged commit e2903a4 into main Apr 28, 2023
@donaldkibet donaldkibet deleted the bug/followup branch April 28, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants