Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Show error message from server when form submission fails #66

Merged
merged 2 commits into from
May 2, 2023

Conversation

donaldkibet
Copy link
Member

@donaldkibet donaldkibet commented Apr 28, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Attempt to extract the exact error message from the server response if the encounter POST request fails when submitting a form.

@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Size Change: -3.85 kB (-1%)

Total Size: 543 kB

ℹ️ View Unchanged
Filename Size Change
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/290.js 81.1 kB 0 B
dist/294.js 2.63 kB 0 B
dist/366.js 6.94 kB 0 B
dist/554.js 32.3 kB -1.93 kB (-6%)
dist/591.js 2.96 kB 0 B
dist/595.js 106 kB 0 B
dist/634.js 777 B 0 B
dist/709.js 2.42 kB 0 B
dist/986.js 193 kB 0 B
dist/main.js 96 kB -1.92 kB (-2%)
dist/openmrs-form-engine-lib.js 3.25 kB 0 B

compressed-size-action

@denniskigen denniskigen changed the title (enhac) Attempt to give cause of failing encounter rest upon form submission (feat) Show error message from the encounter POST request when form submission fails May 2, 2023
@denniskigen denniskigen changed the title (feat) Show error message from the encounter POST request when form submission fails (feat) Show error message from server when form submission fails May 2, 2023
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Donald!

@denniskigen denniskigen merged commit 571767a into main May 2, 2023
@denniskigen denniskigen deleted the error/enhancement branch May 2, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants