Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-2212: hide the form navigation menu for single page forms #92

Closed
wants to merge 1 commit into from

Conversation

jona42-ui
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Add ability to hide form navigation if the form has only one page

Screenshots

Related Issue

https://issues.openmrs.org/browse/O3-2212

Other

@gracepotma
Copy link
Contributor

@jona42-ui please supply a screenshot or screen recording in your PR to assist the reviewers and BAs in reviewing the work :)

@jona42-ui
Copy link
Contributor Author

sure thanks @gracepotma

@gracepotma
Copy link
Contributor

gracepotma commented Jun 28, 2023

@jona42-ui I still don't see a screenshot, am I missing something maybe? Thanks so much for working on this, looking forward to benefiting from it.

@jona42-ui
Copy link
Contributor Author

@gracepotma server is not running well
Screenshot from 2023-06-28 07-21-35

@denniskigen
Copy link
Member

You should be able to run the server. What approach are you using?

@denniskigen denniskigen changed the title O3-2212:React Forms: Don't show Form nav in Single Page forms (feat) O3-2212: Hide the form navigation menu for single page forms Jun 29, 2023
@jona42-ui
Copy link
Contributor Author

After linking the built form engine to the form app in the patient chart app, then running
yarn start --port 3000 --sources packages/esm-form-engine-app;
It seemingly loads the spa app and ends in a white screen;
Screenshot from 2023-06-29 14-14-36

@jona42-ui
Copy link
Contributor Author

Screenshot from 2023-06-29 14-19-35

@samuelmale
Copy link
Member

@jona42-ui you can link the form engine locally within the form builder app by running:

 yarn link ${path-to-form-engine-root-dir-on-your-machine}

Eg.

yarn link /Users/sam/openmrs-form-engine-lib

Then create a form with only one page to test your changes.

@jona42-ui
Copy link
Contributor Author

nav2

@jona42-ui
Copy link
Contributor Author

Screenshot from 2023-06-30 16-38-33

@jona42-ui
Copy link
Contributor Author

@samuelmale @denniskigen

@ebambo
Copy link

ebambo commented Jul 24, 2023

@jona42-ui can you please add a screenshot or video of this working using the React Form Engine. The example shared uses the Angular Form Engine?

@samuelmale
Copy link
Member

samuelmale commented Oct 30, 2023

@jona42-ui are you still working on this?

@jona42-ui
Copy link
Contributor Author

jona42-ui commented Oct 30, 2023

@samuelmale
trying to test out the changes but continuously get this error on linking the form engine locally within the form builder app,any workaround?
image

@jona42-ui jona42-ui changed the title (feat) O3-2212: Hide the form navigation menu for single page forms (feat) O3-2212: hide the form navigation menu for single page forms Oct 30, 2023
@pirupius
Copy link
Member

pirupius commented Apr 9, 2024

Hi @jona42-ui i know it was been long since this work was attended to. The issue with linking was resolved a while back and if you have some time please test this again and share relevant screenshots/video recording so we can get this merged in.

@jona42-ui
Copy link
Contributor Author

okay thanks

@jona42-ui
Copy link
Contributor Author

solved here: #180

closing this as complete.

@jona42-ui jona42-ui closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants