(fix) O3-1895 Edit Past Visit button does not work #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made this a draft because I've been unable to test the routing update in 9a87890. Also I need to update this with respect to the core change. |
|
Updated core and tested using Rebased new changes in and the commit/push hooks did some funny things. Dunno why. I committed the results, anyway. |
|
Anyone know why the build is broken? |
Could the |
denniskigen
force-pushed
the
o3-1895-visits
branch
from
4dfd88c
to
f6701b8
Compare
|
Size Change: -415 kB (-5%) ✅ Total Size: 7.23 MB
ℹ️ View Unchanged
|
|
Haven't completely reviewed this yet, but just trying this quickly I got this: 
This might just be a temporary fluke. |
denniskigen
force-pushed
the
o3-1895-visits
branch
from
f6701b8
to
e8b4e7a
Compare
|
Thanks for the fixup @denniskigen ! And @ibacher , that looks like the old UI exactly. Are you sure you got the changes loaded? I was going to try it again but I think I'm running into a bug in the extension renderer. Using
|
Ah... yes, we had an issue with some of these apps not rendering for reasons I wasn't entirely clear on. This PR dealt with that problem, but you probably need to update the versions of |
|
Fascinating! Okay well it does seem to have fixed it; updated core and now everything is loading nicely. The tooltip formatting looks correct, also.
|
|
🤦 I just realised I got that result because I had forgotten to run the banner app locally. Sorry for the noise! |
ibacher
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Fixes the "edit past visit" functionality. Modifies the active visit tag so you can tell. Fixes active visit tag tooltip styling.
It's split into two commits, the change and a refactor. Review separately for pleasant diffs.
Note that this is not quite right—the Retrospective Entry tag should appear also after clicking "Start visit" and entering a visit in the past. But this requirement maybe needs to be specified a bit better. What if it's a multi-day visit started the previous day, which has not ended yet? Getting the logic right for identifying a retrospective visit is left to O3-2242.
Screenshots
Old:
New:
Related Issue
https://issues.openmrs.org/browse/O3-1895
Other
Depends on openmrs/openmrs-esm-core#724