(fix) O3-2158: Clear order basket search input and trap focus when search gets reset. #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mks-d
changed the title
vasharma05
approved these changes
Aug 21, 2023
4 tasks
AlexanderMizgirev
pushed a commit
to openmrs-sh/openmrs-esm-patient-chart
that referenced
this pull request
Aug 31, 2023
…arch gets reset. (openmrs#1322) * (fix) 03-2158:clear order basket search input and trap focus when search gets reset * (fix) 03-2158:clear order basket search input and trap focus when search get reset * Update drug-search.component.tsx * Update drug-search.component.tsx * Update order-basket-search-results.component.tsx * Update drug-search.resource.tsx * Update order-basket-search-results.component.tsx --------- Co-authored-by: Vineet Sharma <sharmava05@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix)O3-2158:Clear order basket search input and trap focus when search gets reset. i Declare a ref in the Drug Search component that tracks the Search input using the useRef hook and passed it down in Drug Search Result component and Update the logic in it to to accept the ref as a prop. Create a boolean state variable in the OrderBasketSearchResults component that tracks whether the search input was cleared and set to false and create function onClick handler's logic so that it sets the value of the state variable i created above to true. and i added useEffect hook in OrderBasketSearchResults component that traps focus to the Search input if the boolean state variable is true. After trapping focus, it set the state variable back to false.
244932896-ad73d280-6a3c-4767-9e6c-1e05f57c6ee6.mp4
https://issues.openmrs.org/browse/O3-2158