(refactor) O3-3654: Results filter refinement #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -260 kB (-1.78%) Total Size: 14.3 MB
ℹ️ View Unchanged
|
|
@CynthiaKamau ah I see, this might cause some conflict since mine is also somewhat of a UI overhaul. 
still WIP.
|
|
Looping in @reagan-meant |
arodidev
force-pushed
the
results-viewer-revamp
branch
4 times, most recently
from
f29397b
to
322a720
Compare
CynthiaKamau
force-pushed
the
results-viewer-revamp
branch
from
be1c767
to
0ff9f04
Compare
|
@arodidev @CynthiaKamau are we doing away with the idea of panels and trees in favour of only an expandable tree? |
arodidev
force-pushed
the
results-viewer-revamp
branch
from
0ff9f04
to
6664e86
Compare
CynthiaKamau
force-pushed
the
results-viewer-revamp
branch
from
5613845
to
48b09a2
Compare
CynthiaKamau
force-pushed
the
results-viewer-revamp
branch
from
48b09a2
to
501ea55
Compare
CynthiaKamau
approved these changes
Sep 2, 2024
CynthiaKamau
force-pushed
the
results-viewer-revamp
branch
from
c5be10c
to
3fd5cc3
Compare
CynthiaKamau
approved these changes
Sep 3, 2024
CynthiaKamau
force-pushed
the
results-viewer-revamp
branch
from
3fd5cc3
to
3838401
Compare
|
@CynthiaKamau you have some e2e tests failing, I think this is the issue @denniskigen and @jayasanka-sack mentioned |
I fixed the failing ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR introduces a new layout for the results tree filter on the results viewer page, as per these Zeplin design.
Changes include :
Screenshots
Screen.Recording.2024-08-30.at.13.38.21.mov
Related Issue
https://openmrs.atlassian.net/browse/O3-3654
Other