-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-3657: Adapt vitals header styling for small screens #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -84 B (0%) Total Size: 14.3 MB ℹ️ View Unchanged
|
This got @ciaranduffy's seal of approval in the issue thread https://openmrs.atlassian.net/browse/O3-3657?focusedCommentId=142426 |
ibacher
approved these changes
Aug 1, 2024
packages/esm-patient-vitals-app/src/vitals-and-biometrics-header/vitals-header.scss
Outdated
Show resolved
Hide resolved
NethmiRodrigo
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @denniskigen!
denniskigen
force-pushed
the
feat/O3-3657
branch
from
August 6, 2024 21:06
87fd40c
to
fc05704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adapts the Vitals header styling to fix issues with the spacing of items in the Vitals header.
Screenshots
Spacing constraints due to the Overdue tag on the tablet (iPad mini 8-inch)
Fix
result.mp4
Related Issue
Other
https://openmrs.atlassian.net/browse/O3-3657