(fix) Move HtmlFormEntryForm type to patient-common-lib #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 14.3 MB ℹ️ View Unchanged
|
|
Oops, sorry @ibacher and thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
The type
HtmlFormEntryFormwas defined in the patient-forms-app and imported into a few places, most importantly the patient-common-lib. This inadvertently made patient-common-lib have an undeclared, Typescript-only dependency on the patient-forms-app, which means that apps that are not part of this workspace, but depend on the patient common lib cannot correctly pass type-checks.This PR fixes this issue by moving the type to the patient-common-lib and having everything import it from there.
Screenshots
Related Issue
Other