(refactor) O3-4059 Fix Inaccurate Test Result Time Stamps #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +156 B (0%) Total Size: 15.8 MB ℹ️ View Unchanged
|
CynthiaKamau
force-pushed
the
O3-4059
branch
2 times, most recently
from
d1ab540
to
9f9b4cf
Compare
ODORA0
approved these changes
Oct 25, 2024
ibacher
requested changes
Oct 25, 2024
|
|
||
| expect(screen.getByText(/13-jan-2021/i)).toBeInTheDocument(); | ||
| expect(screen.getByText(/2024-10-15/i)).toBeInTheDocument(); |
There was a problem hiding this comment.
The expected format that was replace here should be re-instated. This is the format dates should be displayed in in O3. Please do not invent new date formats.
|
@CynthiaKamau there's an e2e test failling |
|
Its all good now @CynthiaKamau .Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
-I have removed the date after showing that the grouping is based on similar dates.
Related Issue
Other