(feat) O3-4026: Add an icon for the vitals and biometrics link to the left panel #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CynthiaKamau
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks @Munyua123 for this, kindly add a video or image so that guys can easily see the new changes
|
@CynthiaKamau I have added the screenshots |
denniskigen
changed the title
denniskigen
requested changes
Oct 28, 2024
| return ( | ||
| <div key={path}> | ||
| <div key={path} style={{ display: 'flex', alignItems: 'center' }}> |
There was a problem hiding this comment.
Can we move these styles to an .scss file?
| <ConfigurableLink | ||
| className={classNames('cds--side-nav__link', { 'active-left-nav-link': path === navLink })} | ||
| to={`${basePath}/${encodeURIComponent(path)}`} | ||
| > | ||
| {t(title)} | ||
| <span style={{ display: 'flex', alignItems: 'center' }}> |
| @@ -22,13 +23,18 @@ export const DashboardExtension = ({ | |||
| const location = useLocation(); | |||
| const navLink = useMemo(() => decodeURIComponent(last(location.pathname.split('/'))), [location.pathname]); | |||
|
|
|||
| const renderIcon = title === 'Vitals & Biometrics' ? <Activity style={{ marginRight: '8px' }} /> : null; | |||
There was a problem hiding this comment.
Can we use ActivityIcon from the CarbonMRS icon pack in the framework here instead?
|
@denniskigen All the comments above have been noted and iam making the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
I have added a function that allows someone to have an icon before the nav menu title
Screenshots
Related Issue
Other