(refactor) Replace deprecated useSessionUser with useSession
#661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibacher
reviewed
Apr 19, 2022
There was a problem hiding this comment.
Thanks for doing this @denniskigen! Looks like there might be a couple more tests we need mocks for though?
package.json
Outdated
| @@ -19,7 +19,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@jsenv/file-size-impact": "12.1.1", | |||
| "@openmrs/esm-framework": "next", | |||
| "@openmrs/esm-framework": "^3.2.1-pre.1134", | |||
There was a problem hiding this comment.
I think it's best to leave this as next no?
There was a problem hiding this comment.
Yeah, I'll fix it in a subsequent commit
This was referenced Apr 20, 2022
denniskigen
force-pushed
the
refactor-use-session-user
branch
from
7c212bd
to
dbde73d
Compare
ibacher
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR replaces the deprecated
useSessionUserfunction declaration withuseSession. This PR does not introduce any functional changes.Related: openmrs/openmrs-esm-patient-management#177