(feat) - O3-3216 - Ward App - show admitted newborn baby / mother in ward patient card #1303

chibongho · 2024-08-31T01:30:56Z

Requirements

This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
My work includes tests or is validated by existing tests.

Summary

This PR adds the ability to display the mother / child of the patient within the patient card. It does it through an extension row.

This PR is rebased upon another pending PR, so it's a bit hard to review right now. Also, it's set to draft mode because 1) the yarn.lock file depends on a change in core that hasn't been changed it yet and 2) the unit tests are not passing, probably because of 1).

Screenshots

Related Issue

Other

mogoodrich

Sorry for the delay... gave it it quick review and generally LGTM, thanks @chibongho !

mogoodrich · 2024-09-05T13:30:23Z

packages/esm-ward-app/src/ward-patient-card/card-rows/mother-child-row.extension.tsx

+    isLoading: isLoadingMotherData,
+    error: motherDataError,
+  } = useMotherAndChildren(getMotherRequestParams, true, motherAndChildrenRep);
+


I see here why it's annoying to make two queries... :) we can continue to work on revamping this.

github-actions · 2024-09-06T14:58:55Z

Size Change: -329 kB (-5.13%) ✅

Total Size: 6.1 MB

Filename	Change
`packages/esm-appointments-app/dist/198.js`	-250 kB (removed)	🏆
`packages/esm-appointments-app/dist/385.js`	-31.1 kB (removed)	🏆
`packages/esm-appointments-app/dist/440.js`	-16.6 kB (removed)	🏆
`packages/esm-ward-app/dist/917.js`	-31.6 kB (removed)	🏆

ℹ️ View Unchanged

Filename	Size	Change
`packages/esm-active-visits-app/dist/106.js`	8.63 kB	0 B
`packages/esm-active-visits-app/dist/130.js`	344 kB	-98 B (-0.03%)
`packages/esm-active-visits-app/dist/233.js`	3.37 kB	0 B
`packages/esm-active-visits-app/dist/271.js`	800 B	0 B
`packages/esm-active-visits-app/dist/316.js`	42.9 kB	0 B
`packages/esm-active-visits-app/dist/319.js`	709 B	0 B
`packages/esm-active-visits-app/dist/325.js`	3.09 kB	0 B
`packages/esm-active-visits-app/dist/443.js`	6.98 kB	-24 B (-0.34%)
`packages/esm-active-visits-app/dist/460.js`	824 B	0 B
`packages/esm-active-visits-app/dist/574.js`	615 B	0 B
`packages/esm-active-visits-app/dist/586.js`	53.5 kB	0 B
`packages/esm-active-visits-app/dist/6.js`	26.2 kB	0 B
`packages/esm-active-visits-app/dist/644.js`	800 B	0 B
`packages/esm-active-visits-app/dist/725.js`	643 B	0 B
`packages/esm-active-visits-app/dist/757.js`	721 B	0 B
`packages/esm-active-visits-app/dist/784.js`	2.63 kB	0 B
`packages/esm-active-visits-app/dist/788.js`	628 B	0 B
`packages/esm-active-visits-app/dist/807.js`	959 B	0 B
`packages/esm-active-visits-app/dist/814.js`	3.04 kB	0 B
`packages/esm-active-visits-app/dist/833.js`	765 B	0 B
`packages/esm-active-visits-app/dist/879.js`	3.02 kB	0 B
`packages/esm-active-visits-app/dist/967.js`	611 B	0 B
`packages/esm-active-visits-app/dist/main.js`	81.9 kB	0 B
`packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js`	3.32 kB	0 B
`packages/esm-appointments-app/dist/130.js`	344 kB	-95 B (-0.03%)
`packages/esm-appointments-app/dist/2.js`	2.23 kB	0 B
`packages/esm-appointments-app/dist/265.js`	1.79 kB	0 B
`packages/esm-appointments-app/dist/271.js`	2.32 kB	0 B
`packages/esm-appointments-app/dist/292.js`	249 kB	0 B
`packages/esm-appointments-app/dist/319.js`	2.15 kB	0 B
`packages/esm-appointments-app/dist/325.js`	3.08 kB	0 B
`packages/esm-appointments-app/dist/372.js`	2.57 kB	0 B
`packages/esm-appointments-app/dist/460.js`	2.37 kB	0 B
`packages/esm-appointments-app/dist/501.js`	7.02 kB	-8 B (-0.11%)
`packages/esm-appointments-app/dist/574.js`	2.02 kB	0 B
`packages/esm-appointments-app/dist/581.js`	9.03 kB	0 B
`packages/esm-appointments-app/dist/591.js`	16.8 kB	0 B
`packages/esm-appointments-app/dist/644.js`	2.32 kB	0 B
`packages/esm-appointments-app/dist/729.js`	136 kB	0 B
`packages/esm-appointments-app/dist/757.js`	2.21 kB	0 B
`packages/esm-appointments-app/dist/784.js`	2.62 kB	0 B
`packages/esm-appointments-app/dist/788.js`	1.94 kB	0 B
`packages/esm-appointments-app/dist/807.js`	2.56 kB	0 B
`packages/esm-appointments-app/dist/833.js`	2.3 kB	0 B
`packages/esm-appointments-app/dist/834.js`	16.7 kB	0 B
`packages/esm-appointments-app/dist/85.js`	30.4 kB	0 B
`packages/esm-appointments-app/dist/903.js`	879 B	0 B
`packages/esm-appointments-app/dist/main.js`	403 kB	+5 B (0%)
`packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js`	3.38 kB	0 B
`packages/esm-bed-management-app/dist/130.js`	345 kB	-88 B (-0.03%)
`packages/esm-bed-management-app/dist/148.js`	1.22 kB	0 B
`packages/esm-bed-management-app/dist/169.js`	6.98 kB	+1 B (+0.01%)
`packages/esm-bed-management-app/dist/271.js`	680 B	0 B
`packages/esm-bed-management-app/dist/319.js`	680 B	0 B
`packages/esm-bed-management-app/dist/325.js`	3.09 kB	0 B
`packages/esm-bed-management-app/dist/339.js`	50.2 kB	0 B
`packages/esm-bed-management-app/dist/455.js`	26.5 kB	0 B
`packages/esm-bed-management-app/dist/460.js`	680 B	0 B
`packages/esm-bed-management-app/dist/501.js`	7.03 kB	-8 B (-0.11%)
`packages/esm-bed-management-app/dist/542.js`	395 B	0 B
`packages/esm-bed-management-app/dist/574.js`	681 B	0 B
`packages/esm-bed-management-app/dist/591.js`	16.8 kB	0 B
`packages/esm-bed-management-app/dist/644.js`	680 B	0 B
`packages/esm-bed-management-app/dist/757.js`	731 B	0 B
`packages/esm-bed-management-app/dist/766.js`	113 kB	-10 B (-0.01%)
`packages/esm-bed-management-app/dist/784.js`	2.63 kB	0 B
`packages/esm-bed-management-app/dist/788.js`	680 B	0 B
`packages/esm-bed-management-app/dist/807.js`	680 B	0 B
`packages/esm-bed-management-app/dist/833.js`	680 B	0 B
`packages/esm-bed-management-app/dist/main.js`	3.87 kB	0 B
`packages/esm-bed-management-app/dist/openmrs-esm-bed-management-app.js`	3.25 kB	0 B
`packages/esm-patient-list-management-app/dist/130.js`	344 kB	-97 B (-0.03%)
`packages/esm-patient-list-management-app/dist/233.js`	3.38 kB	0 B
`packages/esm-patient-list-management-app/dist/271.js`	1.58 kB	0 B
`packages/esm-patient-list-management-app/dist/319.js`	1.51 kB	0 B
`packages/esm-patient-list-management-app/dist/325.js`	3.09 kB	0 B
`packages/esm-patient-list-management-app/dist/37.js`	8.38 kB	0 B
`packages/esm-patient-list-management-app/dist/443.js`	6.98 kB	-22 B (-0.31%)
`packages/esm-patient-list-management-app/dist/455.js`	57.7 kB	0 B
`packages/esm-patient-list-management-app/dist/460.js`	1.72 kB	0 B
`packages/esm-patient-list-management-app/dist/574.js`	1.33 kB	0 B
`packages/esm-patient-list-management-app/dist/591.js`	16.9 kB	0 B
`packages/esm-patient-list-management-app/dist/644.js`	1.58 kB	0 B
`packages/esm-patient-list-management-app/dist/658.js`	102 kB	0 B
`packages/esm-patient-list-management-app/dist/757.js`	1.58 kB	0 B
`packages/esm-patient-list-management-app/dist/784.js`	2.63 kB	0 B
`packages/esm-patient-list-management-app/dist/788.js`	1.34 kB	0 B
`packages/esm-patient-list-management-app/dist/807.js`	1.85 kB	0 B
`packages/esm-patient-list-management-app/dist/814.js`	3.05 kB	0 B
`packages/esm-patient-list-management-app/dist/833.js`	1.59 kB	0 B
`packages/esm-patient-list-management-app/dist/main.js`	162 kB	0 B
`packages/esm-patient-list-management-app/dist/openmrs-esm-patient-list-management-app.js`	3.3 kB	0 B
`packages/esm-patient-registration-app/dist/130.js`	344 kB	-99 B (-0.03%)
`packages/esm-patient-registration-app/dist/169.js`	6.71 kB	0 B
`packages/esm-patient-registration-app/dist/2.js`	2.24 kB	0 B
`packages/esm-patient-registration-app/dist/271.js`	2.13 kB	0 B
`packages/esm-patient-registration-app/dist/319.js`	2.05 kB	0 B
`packages/esm-patient-registration-app/dist/325.js`	3.09 kB	0 B
`packages/esm-patient-registration-app/dist/371.js`	547 B	+1 B (+0.18%)
`packages/esm-patient-registration-app/dist/372.js`	2.57 kB	0 B
`packages/esm-patient-registration-app/dist/460.js`	2.22 kB	0 B
`packages/esm-patient-registration-app/dist/501.js`	7.03 kB	-10 B (-0.14%)
`packages/esm-patient-registration-app/dist/574.js`	2.04 kB	0 B
`packages/esm-patient-registration-app/dist/591.js`	16.8 kB	0 B
`packages/esm-patient-registration-app/dist/623.js`	6.19 kB	0 B
`packages/esm-patient-registration-app/dist/644.js`	2.13 kB	0 B
`packages/esm-patient-registration-app/dist/662.js`	453 B	0 B
`packages/esm-patient-registration-app/dist/700.js`	69.6 kB	0 B
`packages/esm-patient-registration-app/dist/757.js`	2.15 kB	0 B
`packages/esm-patient-registration-app/dist/784.js`	2.63 kB	0 B
`packages/esm-patient-registration-app/dist/788.js`	1.78 kB	0 B
`packages/esm-patient-registration-app/dist/807.js`	2.51 kB	0 B
`packages/esm-patient-registration-app/dist/833.js`	2.06 kB	0 B
`packages/esm-patient-registration-app/dist/879.js`	3.03 kB	0 B
`packages/esm-patient-registration-app/dist/998.js`	67.2 kB	+2 B (0%)
`packages/esm-patient-registration-app/dist/main.js`	137 kB	+3 B (0%)
`packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js`	3.34 kB	0 B
`packages/esm-patient-search-app/dist/130.js`	344 kB	-97 B (-0.03%)
`packages/esm-patient-search-app/dist/233.js`	3.37 kB	0 B
`packages/esm-patient-search-app/dist/271.js`	920 B	0 B
`packages/esm-patient-search-app/dist/319.js`	861 B	0 B
`packages/esm-patient-search-app/dist/325.js`	3.09 kB	0 B
`packages/esm-patient-search-app/dist/334.js`	24.6 kB	0 B
`packages/esm-patient-search-app/dist/443.js`	6.98 kB	-23 B (-0.33%)
`packages/esm-patient-search-app/dist/460.js`	939 B	0 B
`packages/esm-patient-search-app/dist/574.js`	742 B	0 B
`packages/esm-patient-search-app/dist/591.js`	16.8 kB	0 B
`packages/esm-patient-search-app/dist/634.js`	52 kB	0 B
`packages/esm-patient-search-app/dist/644.js`	920 B	0 B
`packages/esm-patient-search-app/dist/757.js`	871 B	0 B
`packages/esm-patient-search-app/dist/784.js`	2.63 kB	0 B
`packages/esm-patient-search-app/dist/788.js`	736 B	0 B
`packages/esm-patient-search-app/dist/807.js`	1.04 kB	0 B
`packages/esm-patient-search-app/dist/814.js`	3.05 kB	0 B
`packages/esm-patient-search-app/dist/833.js`	877 B	0 B
`packages/esm-patient-search-app/dist/main.js`	77.4 kB	0 B
`packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js`	3.29 kB	0 B
`packages/esm-service-queues-app/dist/130.js`	344 kB	-97 B (-0.03%)
`packages/esm-service-queues-app/dist/169.js`	6.98 kB	+1 B (+0.01%)
`packages/esm-service-queues-app/dist/199.js`	1.35 kB	0 B
`packages/esm-service-queues-app/dist/2.js`	2.23 kB	0 B
`packages/esm-service-queues-app/dist/236.js`	5.84 kB	0 B
`packages/esm-service-queues-app/dist/271.js`	4.56 kB	0 B
`packages/esm-service-queues-app/dist/282.js`	8.97 kB	0 B
`packages/esm-service-queues-app/dist/319.js`	3.86 kB	0 B
`packages/esm-service-queues-app/dist/325.js`	3.09 kB	0 B
`packages/esm-service-queues-app/dist/366.js`	7.86 kB	0 B
`packages/esm-service-queues-app/dist/372.js`	2.57 kB	0 B
`packages/esm-service-queues-app/dist/392.js`	7.85 kB	0 B
`packages/esm-service-queues-app/dist/460.js`	4.78 kB	0 B
`packages/esm-service-queues-app/dist/501.js`	7.03 kB	-4 B (-0.06%)
`packages/esm-service-queues-app/dist/574.js`	3.84 kB	0 B
`packages/esm-service-queues-app/dist/591.js`	16.8 kB	0 B
`packages/esm-service-queues-app/dist/6.js`	1.75 kB	0 B
`packages/esm-service-queues-app/dist/604.js`	6.96 kB	0 B
`packages/esm-service-queues-app/dist/644.js`	4.57 kB	0 B
`packages/esm-service-queues-app/dist/665.js`	160 kB	-5 B (0%)
`packages/esm-service-queues-app/dist/670.js`	10 kB	0 B
`packages/esm-service-queues-app/dist/727.js`	8.1 kB	0 B
`packages/esm-service-queues-app/dist/748.js`	116 kB	0 B
`packages/esm-service-queues-app/dist/752.js`	1.62 kB	0 B
`packages/esm-service-queues-app/dist/757.js`	4.14 kB	0 B
`packages/esm-service-queues-app/dist/760.js`	7.13 kB	0 B
`packages/esm-service-queues-app/dist/784.js`	2.63 kB	0 B
`packages/esm-service-queues-app/dist/788.js`	3.86 kB	0 B
`packages/esm-service-queues-app/dist/800.js`	1.68 kB	0 B
`packages/esm-service-queues-app/dist/807.js`	5.14 kB	0 B
`packages/esm-service-queues-app/dist/818.js`	2.55 kB	0 B
`packages/esm-service-queues-app/dist/828.js`	1.39 kB	0 B
`packages/esm-service-queues-app/dist/833.js`	4.46 kB	0 B
`packages/esm-service-queues-app/dist/911.js`	7.76 kB	0 B
`packages/esm-service-queues-app/dist/940.js`	21.4 kB	0 B
`packages/esm-service-queues-app/dist/main.js`	276 kB	-1 B (0%)
`packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js`	3.31 kB	0 B
`packages/esm-ward-app/dist/109.js`	344 B	0 B
`packages/esm-ward-app/dist/125.js`	5.68 kB	-3 B (-0.05%)
`packages/esm-ward-app/dist/130.js`	344 kB	-97 B (-0.03%)
`packages/esm-ward-app/dist/169.js`	6.97 kB	+1 B (+0.01%)
`packages/esm-ward-app/dist/2.js`	2.23 kB	0 B
`packages/esm-ward-app/dist/269.js`	768 B	+15 B (+1.99%)
`packages/esm-ward-app/dist/314.js`	31.9 kB	0 B
`packages/esm-ward-app/dist/325.js`	3.08 kB	0 B
`packages/esm-ward-app/dist/342.js`	1.08 kB	0 B
`packages/esm-ward-app/dist/348.js`	349 B	0 B
`packages/esm-ward-app/dist/372.js`	2.56 kB	0 B
`packages/esm-ward-app/dist/466.js`	393 B	+30 B (+8.26%)	🔍
`packages/esm-ward-app/dist/500.js`	4.99 kB	0 B
`packages/esm-ward-app/dist/501.js`	7.02 kB	-12 B (-0.17%)
`packages/esm-ward-app/dist/53.js`	11.3 kB	0 B
`packages/esm-ward-app/dist/559.js`	342 B	0 B
`packages/esm-ward-app/dist/574.js`	1.37 kB	0 B
`packages/esm-ward-app/dist/577.js`	18 kB	-1 B (-0.01%)
`packages/esm-ward-app/dist/591.js`	16.8 kB	0 B
`packages/esm-ward-app/dist/659.js`	9.89 kB	0 B
`packages/esm-ward-app/dist/701.js`	3.48 kB	0 B
`packages/esm-ward-app/dist/749.js`	8.18 kB	+33 B (+0.4%)
`packages/esm-ward-app/dist/767.js`	648 B	0 B
`packages/esm-ward-app/dist/784.js`	2.62 kB	0 B
`packages/esm-ward-app/dist/922.js`	9.3 kB	-1 B (-0.01%)
`packages/esm-ward-app/dist/930.js`	35.1 kB	-9 B (-0.03%)
`packages/esm-ward-app/dist/940.js`	21.4 kB	0 B
`packages/esm-ward-app/dist/969.js`	202 B	0 B
`packages/esm-ward-app/dist/main.js`	67.5 kB	+237 B (+0.35%)
`packages/esm-ward-app/dist/openmrs-esm-ward-app.js`	3.29 kB	0 B

_{compressed-size-action}

kb019 and others added 10 commits June 26, 2024 19:38

feat-metrics

e710137

resolve conflicts

f56fc3a

(fix) O3-3709 - ward app - handle pagination

5fb7a29

update metrics

5104ac5

mother child stash

1338b97

Merge remote-tracking branch 'bhargav/feat/metrics' into mother

fd10eee

what a mess

8385caa

stash

d353412

good to go

2aadaf3

(fix) O3-3709 - ward app - handle pagination

aa83184

chibongho force-pushed the mother branch 2 times, most recently from e0fe086 to aea4e0a Compare August 31, 2024 04:10

Merge branch 'ward-pagination' into mother

ba204fd

chibongho force-pushed the mother branch from aea4e0a to ba204fd Compare August 31, 2024 04:15

chibongho added 2 commits September 3, 2024 09:52

remove orig files

6dfbe10

Merge branch 'ward-pagination' into mother

faaa059

chibongho requested review from usamaidrsk, brandones, mogoodrich and vasharma05 September 3, 2024 14:53

mogoodrich approved these changes Sep 5, 2024

View reviewed changes

chibongho added 3 commits September 5, 2024 09:55

(fix) O3-3709 - ward app - handle pagination

bc4ee1c

Merge branch 'ward-pagination' into mother

9314d89

fix tests

eb4f6d1

chibongho marked this pull request as ready for review September 6, 2024 14:48

Merge remote-tracking branch 'origin/main' into mother

1046729

chibongho merged commit 07d0432 into main Sep 6, 2024
6 checks passed

chibongho deleted the mother branch September 6, 2024 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(feat) - O3-3216 - Ward App - show admitted newborn baby / mother in ward patient card #1303

(feat) - O3-3216 - Ward App - show admitted newborn baby / mother in ward patient card #1303

chibongho commented Aug 31, 2024 •

edited

Loading

mogoodrich left a comment

mogoodrich Sep 5, 2024

github-actions bot commented Sep 6, 2024

(feat) - O3-3216 - Ward App - show admitted newborn baby / mother in ward patient card #1303

(feat) - O3-3216 - Ward App - show admitted newborn baby / mother in ward patient card #1303

Conversation

chibongho commented Aug 31, 2024 • edited Loading

Requirements

Summary

Screenshots

Related Issue

Other

mogoodrich left a comment

Choose a reason for hiding this comment

mogoodrich Sep 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 6, 2024

chibongho commented Aug 31, 2024 •

edited

Loading