Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Delay display of menu item tooltips by 500ms #466

Merged
merged 1 commit into from
Nov 17, 2022
Merged

(feat) Delay display of menu item tooltips by 500ms #466

merged 1 commit into from
Nov 17, 2022

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Nov 8, 2022 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Ups the HeaderGlobalAction component's enterDelayMs prop's value from 100ms to 500ms. This delay is sufficient for the tooltips not to overlap when a user hovers over menu items in the navigation bar.

Related Issue

https://issues.openmrs.org/browse/O3-1585

Slack discussion https://openmrs.slack.com/archives/CKS32D55G/p1667573248471719.

@denniskigen denniskigen mentioned this pull request Nov 8, 2022
Merged
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Size Change: +25 B (0%)

Total Size: 2.16 MB

ℹ️ View Unchanged
Filename Size Change
packages/esm-active-visits-app/dist/150.js 810 B 0 B
packages/esm-active-visits-app/dist/184.js 6.54 kB 0 B
packages/esm-active-visits-app/dist/316.js 42.9 kB 0 B
packages/esm-active-visits-app/dist/319.js 128 B 0 B
packages/esm-active-visits-app/dist/399.js 5.58 kB 0 B
packages/esm-active-visits-app/dist/574.js 517 B 0 B
packages/esm-active-visits-app/dist/709.js 6.66 kB 0 B
packages/esm-active-visits-app/dist/723.js 53.5 kB 0 B
packages/esm-active-visits-app/dist/784.js 2.63 kB 0 B
packages/esm-active-visits-app/dist/807.js 817 B 0 B
packages/esm-active-visits-app/dist/858.js 111 kB 0 B
packages/esm-active-visits-app/dist/879.js 2.93 kB 0 B
packages/esm-active-visits-app/dist/main.js 3.23 kB 0 B
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.22 kB 0 B
packages/esm-appointments-app/dist/153.js 266 B 0 B
packages/esm-appointments-app/dist/162.js 11.2 kB 0 B
packages/esm-appointments-app/dist/183.js 3.59 kB 0 B
packages/esm-appointments-app/dist/268.js 2.07 kB 0 B
packages/esm-appointments-app/dist/308.js 7.94 kB 0 B
packages/esm-appointments-app/dist/319.js 124 B 0 B
packages/esm-appointments-app/dist/339.js 29.7 kB 0 B
packages/esm-appointments-app/dist/34.js 8.16 kB 0 B
packages/esm-appointments-app/dist/351.js 1.84 kB 0 B
packages/esm-appointments-app/dist/352.js 6.65 kB 0 B
packages/esm-appointments-app/dist/39.js 448 B 0 B
packages/esm-appointments-app/dist/429.js 4.85 kB 0 B
packages/esm-appointments-app/dist/45.js 10.6 kB 0 B
packages/esm-appointments-app/dist/48.js 16.5 kB 0 B
packages/esm-appointments-app/dist/497.js 4.55 kB 0 B
packages/esm-appointments-app/dist/574.js 1.83 kB 0 B
packages/esm-appointments-app/dist/685.js 2.6 kB 0 B
packages/esm-appointments-app/dist/717.js 598 B 0 B
packages/esm-appointments-app/dist/784.js 2.63 kB 0 B
packages/esm-appointments-app/dist/807.js 2.56 kB 0 B
packages/esm-appointments-app/dist/821.js 8.21 kB 0 B
packages/esm-appointments-app/dist/841.js 7.39 kB 0 B
packages/esm-appointments-app/dist/843.js 6.71 kB 0 B
packages/esm-appointments-app/dist/858.js 111 kB 0 B
packages/esm-appointments-app/dist/905.js 4.19 kB 0 B
packages/esm-appointments-app/dist/998.js 146 kB 0 B
packages/esm-appointments-app/dist/main.js 148 kB 0 B
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.19 kB 0 B
packages/esm-outpatient-app/dist/121.js 1.03 kB 0 B
packages/esm-outpatient-app/dist/124.js 150 kB 0 B
packages/esm-outpatient-app/dist/146.js 5.28 kB 0 B
packages/esm-outpatient-app/dist/162.js 1.03 kB 0 B
packages/esm-outpatient-app/dist/196.js 4.56 kB 0 B
packages/esm-outpatient-app/dist/242.js 242 B 0 B
packages/esm-outpatient-app/dist/303.js 509 B 0 B
packages/esm-outpatient-app/dist/319.js 125 B 0 B
packages/esm-outpatient-app/dist/324.js 4.81 kB 0 B
packages/esm-outpatient-app/dist/325.js 936 B 0 B
packages/esm-outpatient-app/dist/34.js 16.5 kB 0 B
packages/esm-outpatient-app/dist/352.js 6.65 kB 0 B
packages/esm-outpatient-app/dist/385.js 2.38 kB 0 B
packages/esm-outpatient-app/dist/387.js 258 B 0 B
packages/esm-outpatient-app/dist/40.js 2.49 kB 0 B
packages/esm-outpatient-app/dist/485.js 4.76 kB 0 B
packages/esm-outpatient-app/dist/574.js 2.58 kB 0 B
packages/esm-outpatient-app/dist/650.js 5.57 kB 0 B
packages/esm-outpatient-app/dist/655.js 5.01 kB 0 B
packages/esm-outpatient-app/dist/693.js 5.44 kB 0 B
packages/esm-outpatient-app/dist/711.js 9.9 kB 0 B
packages/esm-outpatient-app/dist/717.js 600 B 0 B
packages/esm-outpatient-app/dist/784.js 2.63 kB 0 B
packages/esm-outpatient-app/dist/807.js 3.84 kB 0 B
packages/esm-outpatient-app/dist/843.js 6.71 kB 0 B
packages/esm-outpatient-app/dist/858.js 111 kB 0 B
packages/esm-outpatient-app/dist/885.js 3.06 kB 0 B
packages/esm-outpatient-app/dist/889.js 24.6 kB 0 B
packages/esm-outpatient-app/dist/937.js 6.27 kB 0 B
packages/esm-outpatient-app/dist/94.js 2.85 kB 0 B
packages/esm-outpatient-app/dist/main.js 152 kB 0 B
packages/esm-outpatient-app/dist/openmrs-esm-outpatient-app.js 3.19 kB 0 B
packages/esm-patient-list-app/dist/163.js 2.45 kB 0 B
packages/esm-patient-list-app/dist/196.js 99.8 kB 0 B
packages/esm-patient-list-app/dist/299.js 12.2 kB 0 B
packages/esm-patient-list-app/dist/34.js 16.5 kB 0 B
packages/esm-patient-list-app/dist/483.js 1.32 kB 0 B
packages/esm-patient-list-app/dist/537.js 528 B 0 B
packages/esm-patient-list-app/dist/574.js 787 B 0 B
packages/esm-patient-list-app/dist/663.js 1.76 kB 0 B
packages/esm-patient-list-app/dist/717.js 497 B 0 B
packages/esm-patient-list-app/dist/733.js 5.42 kB 0 B
packages/esm-patient-list-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-list-app/dist/801.js 282 B 0 B
packages/esm-patient-list-app/dist/807.js 1.18 kB 0 B
packages/esm-patient-list-app/dist/843.js 6.71 kB 0 B
packages/esm-patient-list-app/dist/857.js 4.25 kB 0 B
packages/esm-patient-list-app/dist/858.js 111 kB 0 B
packages/esm-patient-list-app/dist/905.js 2.89 kB 0 B
packages/esm-patient-list-app/dist/main.js 3.25 kB 0 B
packages/esm-patient-list-app/dist/openmrs-esm-patient-list-app.js 3.19 kB 0 B
packages/esm-patient-registration-app/dist/100.js 6.85 kB 0 B
packages/esm-patient-registration-app/dist/154.js 28.3 kB 0 B
packages/esm-patient-registration-app/dist/206.js 651 B +12 B (+2%)
packages/esm-patient-registration-app/dist/242.js 2.97 kB 0 B
packages/esm-patient-registration-app/dist/34.js 16.5 kB 0 B
packages/esm-patient-registration-app/dist/375.js 1.88 kB 0 B
packages/esm-patient-registration-app/dist/430.js 67.5 kB 0 B
packages/esm-patient-registration-app/dist/470.js 12.1 kB 0 B
packages/esm-patient-registration-app/dist/574.js 1.31 kB 0 B
packages/esm-patient-registration-app/dist/635.js 451 B 0 B
packages/esm-patient-registration-app/dist/658.js 23.4 kB 0 B
packages/esm-patient-registration-app/dist/686.js 9.63 kB 0 B
packages/esm-patient-registration-app/dist/735.js 459 B 0 B
packages/esm-patient-registration-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-registration-app/dist/807.js 2.02 kB 0 B
packages/esm-patient-registration-app/dist/854.js 23.4 kB 0 B
packages/esm-patient-registration-app/dist/858.js 111 kB 0 B
packages/esm-patient-registration-app/dist/975.js 419 B 0 B
packages/esm-patient-registration-app/dist/main.js 21.2 kB 0 B
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.19 kB 0 B
packages/esm-patient-search-app/dist/148.js 14 kB 0 B
packages/esm-patient-search-app/dist/150.js 2.1 kB 0 B
packages/esm-patient-search-app/dist/219.js 2.74 kB +13 B (0%)
packages/esm-patient-search-app/dist/319.js 186 B 0 B
packages/esm-patient-search-app/dist/327.js 1.05 kB 0 B
packages/esm-patient-search-app/dist/34.js 16.5 kB 0 B
packages/esm-patient-search-app/dist/368.js 30.5 kB 0 B
packages/esm-patient-search-app/dist/574.js 746 B 0 B
packages/esm-patient-search-app/dist/580.js 1.38 kB 0 B
packages/esm-patient-search-app/dist/614.js 3.6 kB 0 B
packages/esm-patient-search-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-search-app/dist/750.js 1.76 kB 0 B
packages/esm-patient-search-app/dist/757.js 642 B 0 B
packages/esm-patient-search-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-search-app/dist/807.js 1.11 kB 0 B
packages/esm-patient-search-app/dist/858.js 111 kB 0 B
packages/esm-patient-search-app/dist/984.js 3.77 kB 0 B
packages/esm-patient-search-app/dist/main.js 3.25 kB 0 B
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.18 kB 0 B

compressed-size-action

pirupius
pirupius approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I remember us talking about this last week during the O3 all 👍🏾

@denniskigen
Copy link
Member Author

Thanks, @pirupius!

@denniskigen denniskigen merged commit 0d8dd16 into main Nov 17, 2022
@denniskigen denniskigen deleted the feat/delay-tooltips branch November 17, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirupius pirupius pirupius approved these changes

@ibacher ibacher Awaiting requested review from ibacher

@vasharma05 vasharma05 Awaiting requested review from vasharma05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniskigen @pirupius