Revert "O3-3002: Queue Module - REST endpoints can be accessed without authentication." #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t authen…" This reverts commit 43117c9.
|
@mseaton what would be your recommended approach to address the issues that you are facing with your implementation? We just want to prevent anonymous access to this module's functionality. |
|
@dkayiwa - I made some suggestions just now on the ticket - lemme know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #65
@dkayiwa / @IamMujuziMoses - unfortunately this commit appears to be breaking our implementation due to the new privileges required. I can't currently access JIRA due to the infrastructure outage to see any past discussion here, so I'm going to revert it for now so we can discuss and figure out the best way to get these improvements committed.