Merge pull request #622 from azizdiakite/master

Improve Swagger typings for getAll
openmrs · Sep 10, 2024 · 4a54c44 · 4a54c44
2 parents 07fd727 + ce023b3
commit 4a54c44
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/...rc/main/java/org/openmrs/module/webservices/docs/swagger/SwaggerSpecificationCreator.java b/...rc/main/java/org/openmrs/module/webservices/docs/swagger/SwaggerSpecificationCreator.java
@@ -132,7 +132,6 @@ private void BuildJSON() {
 			try {
 				initSwagger();
 				addPaths();
-				addDefaultDefinitions();
 				//				addSubclassOperations(); //FIXME uncomment after fixing the method
 			}
 			catch (Exception e) {
@@ -253,7 +252,7 @@ private boolean testOperationImplemented(OperationEnum operation, DelegatingReso
 					if (method == null) {
 						return false;
 					} else {
-						method.invoke(resourceHandler, new RequestContext());
+						method.invoke(resourceHandler, RestConstants.SWAGGER_IMPOSSIBLE_UNIQUE_ID, new RequestContext());
 					}
 
 					break;
@@ -1069,7 +1068,10 @@ private Operation createOperation(DelegatingResourceHandler<?> resourceHandler,
 
 			operation.setSummary("Fetch all non-retired");
 			operation.setOperationId("getAll" + getOperationTitle(resourceHandler, true));
-			operation.addResponse("200", response200.schema(new RefProperty("#/definitions/FetchAll")));
+			operation.addResponse("200",
+					response200.schema(new ArrayProperty(
+						new RefProperty(getSchemaRef(resourceName, resourceParentName, OperationEnum.get)))));
+
 			operation.setParameters(buildPagingParameters());
 			operation.parameter(v);
 			if (((BaseDelegatingResource<?>) resourceHandler).hasTypesDefined()) {