Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSA-10091 - kibana live filtering mechanism #214

Merged
merged 1 commit into from
Oct 5, 2021
Merged

MSA-10091 - kibana live filtering mechanism #214

merged 1 commit into from
Oct 5, 2021

Conversation

Diyal976
Copy link
Contributor

@Diyal976 Diyal976 commented Oct 4, 2021

@Diyal976 Diyal976 merged commit b0076bc into master Oct 5, 2021
@Diyal976 Diyal976 mentioned this pull request Oct 5, 2021
Closed
@abr-ubiqube
Copy link
Contributor

Hello @Diyal976
is this compatible with MSA 2.5?
we are getting this error with 2.5:
PHP Notice: Undefined index: template_id in /opt/fmc_repository/OpenMSA_WF/Analytics/Kibana/Process_Create_Report_Dashboard/Task_Search_Dashboard_Template_Selected.php on line 43 PHP Notice: Undefined index: template_id in /opt/fmc_repository/OpenMSA_WF/Analytics/Kibana/Process_Create_Report_Dashboard/Task_Search_Dashboard_Template_Selected.php on line 51 PHP Notice: Undefined index: template_id in /opt/fmc_repository/OpenMSA_WF/Analytics/Kibana/Process_Create_Report_Dashboard/Task_Search_Dashboard_Template_Selected.php on line 79

it looks related to this:
image

I think that this commit should be reverted from master branch and move to a dev branch 2.6.0 that we will merge once the 2.6.0GA is released

@abr-ubiqube abr-ubiqube mentioned this pull request Oct 6, 2021
Merged
abr-ubiqube added a commit that referenced this pull request Nov 3, 2021
@abr-ubiqube @Diyal976 @ArnaudFosse
MSA-10091 - kibana live filtering mechanism (#214) (#215)
0885dc0 
Co-authored-by: Diyaldine Maoulida <43171051+Diyal976@users.noreply.github.com>
Co-authored-by: ArnaudFosse <34027417+ArnaudFosse@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vignaudo Vignaudo Vignaudo approved these changes

@abr-ubiqube abr-ubiqube Awaiting requested review from abr-ubiqube

@hiro-ubiqube hiro-ubiqube Awaiting requested review from hiro-ubiqube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Diyal976 @abr-ubiqube @Vignaudo