Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Crypto works under node18 #356

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

nojiritakeshi
Copy link
Contributor

When using opennextjs-cloudflare under node18, I get the following error in “crypto”.

file:///home/nojiri/yourself-score/node_modules/@opennextjs/cloudflare/dist/cli/utils/ask-confirmation.js:3
    const questionName = crypto.randomUUUID();

ReferenceError: crypto is not defined

Until node@v18 is deprecated, we think it's ok to import.

Copy link

changeset-bot bot commented Feb 9, 2025

🦋 Changeset detected

Latest commit: 2ed9695

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Feb 9, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@356

commit: 2ed9695

@vicb vicb merged commit 761a312 into opennextjs:main Feb 10, 2025
7 checks passed
@vicb
Copy link
Contributor

vicb commented Feb 10, 2025

Thanks for your PR @nojiritakeshi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants